* [linux-next:master 12420/13171] include/linux/compiler_types.h:602:45: error: call to '__compiletime_assert_293' declared with attribute error: min(burstcnt, len - count - 1) signedness error
@ 2025-12-01 12:18 kernel test robot
2025-12-01 12:42 ` David Laight
0 siblings, 1 reply; 6+ messages in thread
From: kernel test robot @ 2025-12-01 12:18 UTC (permalink / raw)
To: David Laight; +Cc: oe-kbuild-all, Jarkko Sakkinen
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 95cb2fd6ce0ad61af54191fe5ef271d7177f9c3a
commit: 9ce4f8e56bd2ed2bd473572bbd4c1a7f8863487c [12420/13171] drivers/char/tpm: use min() instead of min_t()
config: xtensa-randconfig-r123-20251201 (https://download.01.org/0day-ci/archive/20251201/202512012040.BkoYgkkr-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251201/202512012040.BkoYgkkr-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512012040.BkoYgkkr-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from <command-line>:
drivers/char/tpm/tpm_tis_core.c: In function 'tpm_tis_send_data':
>> include/linux/compiler_types.h:602:45: error: call to '__compiletime_assert_293' declared with attribute error: min(burstcnt, len - count - 1) signedness error
602 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^
include/linux/compiler_types.h:583:25: note: in definition of macro '__compiletime_assert'
583 | prefix ## suffix(); \
| ^~~~~~
include/linux/compiler_types.h:602:9: note: in expansion of macro '_compiletime_assert'
602 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
| ^~~~~~~~~~~~~~~~~~
include/linux/minmax.h:93:9: note: in expansion of macro 'BUILD_BUG_ON_MSG'
93 | BUILD_BUG_ON_MSG(!__types_ok(ux, uy), \
| ^~~~~~~~~~~~~~~~
include/linux/minmax.h:98:9: note: in expansion of macro '__careful_cmp_once'
98 | __careful_cmp_once(op, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_))
| ^~~~~~~~~~~~~~~~~~
include/linux/minmax.h:105:25: note: in expansion of macro '__careful_cmp'
105 | #define min(x, y) __careful_cmp(min, x, y)
| ^~~~~~~~~~~~~
drivers/char/tpm/tpm_tis_core.c:456:28: note: in expansion of macro 'min'
456 | burstcnt = min(burstcnt, len - count - 1);
| ^~~
--
In file included from <command-line>:
tpm_tis_core.c: In function 'tpm_tis_send_data':
>> include/linux/compiler_types.h:602:45: error: call to '__compiletime_assert_293' declared with attribute error: min(burstcnt, len - count - 1) signedness error
602 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^
include/linux/compiler_types.h:583:25: note: in definition of macro '__compiletime_assert'
583 | prefix ## suffix(); \
| ^~~~~~
include/linux/compiler_types.h:602:9: note: in expansion of macro '_compiletime_assert'
602 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
| ^~~~~~~~~~~~~~~~~~
include/linux/minmax.h:93:9: note: in expansion of macro 'BUILD_BUG_ON_MSG'
93 | BUILD_BUG_ON_MSG(!__types_ok(ux, uy), \
| ^~~~~~~~~~~~~~~~
include/linux/minmax.h:98:9: note: in expansion of macro '__careful_cmp_once'
98 | __careful_cmp_once(op, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_))
| ^~~~~~~~~~~~~~~~~~
include/linux/minmax.h:105:25: note: in expansion of macro '__careful_cmp'
105 | #define min(x, y) __careful_cmp(min, x, y)
| ^~~~~~~~~~~~~
tpm_tis_core.c:456:28: note: in expansion of macro 'min'
456 | burstcnt = min(burstcnt, len - count - 1);
| ^~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for OF_GPIO
Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
Selected by [y]:
- GPIO_TB10X [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && (ARC_PLAT_TB10X || COMPILE_TEST [=y])
WARNING: unmet direct dependencies detected for MFD_STMFX
Depends on [n]: HAS_IOMEM [=y] && I2C [=m] && OF [=n]
Selected by [m]:
- PINCTRL_STMFX [=m] && PINCTRL [=y] && I2C [=m] && OF_GPIO [=y] && HAS_IOMEM [=y]
WARNING: unmet direct dependencies detected for I2C_K1
Depends on [n]: I2C [=m] && HAS_IOMEM [=y] && (ARCH_SPACEMIT || COMPILE_TEST [=y]) && OF [=n]
Selected by [m]:
- MFD_SPACEMIT_P1 [=m] && HAS_IOMEM [=y] && (ARCH_SPACEMIT || COMPILE_TEST [=y]) && I2C [=m]
vim +/__compiletime_assert_293 +602 include/linux/compiler_types.h
eb5c2d4b45e3d2 Will Deacon 2020-07-21 588
eb5c2d4b45e3d2 Will Deacon 2020-07-21 589 #define _compiletime_assert(condition, msg, prefix, suffix) \
eb5c2d4b45e3d2 Will Deacon 2020-07-21 590 __compiletime_assert(condition, msg, prefix, suffix)
eb5c2d4b45e3d2 Will Deacon 2020-07-21 591
eb5c2d4b45e3d2 Will Deacon 2020-07-21 592 /**
eb5c2d4b45e3d2 Will Deacon 2020-07-21 593 * compiletime_assert - break build and emit msg if condition is false
eb5c2d4b45e3d2 Will Deacon 2020-07-21 594 * @condition: a compile-time constant condition to check
eb5c2d4b45e3d2 Will Deacon 2020-07-21 595 * @msg: a message to emit if condition is false
eb5c2d4b45e3d2 Will Deacon 2020-07-21 596 *
eb5c2d4b45e3d2 Will Deacon 2020-07-21 597 * In tradition of POSIX assert, this macro will break the build if the
eb5c2d4b45e3d2 Will Deacon 2020-07-21 598 * supplied condition is *false*, emitting the supplied error message if the
eb5c2d4b45e3d2 Will Deacon 2020-07-21 599 * compiler has support to do so.
eb5c2d4b45e3d2 Will Deacon 2020-07-21 600 */
eb5c2d4b45e3d2 Will Deacon 2020-07-21 601 #define compiletime_assert(condition, msg) \
eb5c2d4b45e3d2 Will Deacon 2020-07-21 @602 _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
eb5c2d4b45e3d2 Will Deacon 2020-07-21 603
:::::: The code at line 602 was first introduced by commit
:::::: eb5c2d4b45e3d2d5d052ea6b8f1463976b1020d5 compiler.h: Move compiletime_assert() macros into compiler_types.h
:::::: TO: Will Deacon <will@kernel.org>
:::::: CC: Will Deacon <will@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [linux-next:master 12420/13171] include/linux/compiler_types.h:602:45: error: call to '__compiletime_assert_293' declared with attribute error: min(burstcnt, len - count - 1) signedness error
2025-12-01 12:18 [linux-next:master 12420/13171] include/linux/compiler_types.h:602:45: error: call to '__compiletime_assert_293' declared with attribute error: min(burstcnt, len - count - 1) signedness error kernel test robot
@ 2025-12-01 12:42 ` David Laight
2025-12-01 14:26 ` Jarkko Sakkinen
0 siblings, 1 reply; 6+ messages in thread
From: David Laight @ 2025-12-01 12:42 UTC (permalink / raw)
To: kernel test robot; +Cc: oe-kbuild-all, Jarkko Sakkinen
On Mon, 1 Dec 2025 20:18:45 +0800
kernel test robot <lkp@intel.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 95cb2fd6ce0ad61af54191fe5ef271d7177f9c3a
> commit: 9ce4f8e56bd2ed2bd473572bbd4c1a7f8863487c [12420/13171] drivers/char/tpm: use min() instead of min_t()
> config: xtensa-randconfig-r123-20251201 (https://download.01.org/0day-ci/archive/20251201/202512012040.BkoYgkkr-lkp@intel.com/config)
> compiler: xtensa-linux-gcc (GCC) 11.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251201/202512012040.BkoYgkkr-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202512012040.BkoYgkkr-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> In file included from <command-line>:
> drivers/char/tpm/tpm_tis_core.c: In function 'tpm_tis_send_data':
> >> include/linux/compiler_types.h:602:45: error: call to '__compiletime_assert_293' declared with attribute error: min(burstcnt, len - count - 1) signedness error
...
> drivers/char/tpm/tpm_tis_core.c:456:28: note: in expansion of macro 'min'
> 456 | burstcnt = min(burstcnt, len - count - 1);
I hate compiler differences.
Usually the:
if (burstcnt < 0) {
...
goto out_err;
}
a few lines higher is enough to make the statically_true(burstcnt >= 0) pass.
I'm not sure why it doesn't here.
David
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [linux-next:master 12420/13171] include/linux/compiler_types.h:602:45: error: call to '__compiletime_assert_293' declared with attribute error: min(burstcnt, len - count - 1) signedness error
2025-12-01 12:42 ` David Laight
@ 2025-12-01 14:26 ` Jarkko Sakkinen
2025-12-01 14:27 ` Jarkko Sakkinen
2025-12-01 16:12 ` David Laight
0 siblings, 2 replies; 6+ messages in thread
From: Jarkko Sakkinen @ 2025-12-01 14:26 UTC (permalink / raw)
To: David Laight; +Cc: kernel test robot, oe-kbuild-all, Linus Torvalds
On Mon, Dec 01, 2025 at 12:42:56PM +0000, David Laight wrote:
> On Mon, 1 Dec 2025 20:18:45 +0800
> kernel test robot <lkp@intel.com> wrote:
>
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head: 95cb2fd6ce0ad61af54191fe5ef271d7177f9c3a
> > commit: 9ce4f8e56bd2ed2bd473572bbd4c1a7f8863487c [12420/13171] drivers/char/tpm: use min() instead of min_t()
> > config: xtensa-randconfig-r123-20251201 (https://download.01.org/0day-ci/archive/20251201/202512012040.BkoYgkkr-lkp@intel.com/config)
> > compiler: xtensa-linux-gcc (GCC) 11.5.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251201/202512012040.BkoYgkkr-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202512012040.BkoYgkkr-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>):
> >
> > In file included from <command-line>:
> > drivers/char/tpm/tpm_tis_core.c: In function 'tpm_tis_send_data':
> > >> include/linux/compiler_types.h:602:45: error: call to '__compiletime_assert_293' declared with attribute error: min(burstcnt, len - count - 1) signedness error
> ...
> > drivers/char/tpm/tpm_tis_core.c:456:28: note: in expansion of macro 'min'
> > 456 | burstcnt = min(burstcnt, len - count - 1);
>
> I hate compiler differences.
> Usually the:
> if (burstcnt < 0) {
> ...
> goto out_err;
> }
> a few lines higher is enough to make the statically_true(burstcnt >= 0) pass.
>
> I'm not sure why it doesn't here.
>
> David
It is already part of PR, which I've revised already once in order to
drop one patch:
https://lore.kernel.org/linux-integrity/aSnQZ4pRWqJai6FW@kernel.org/T/#u
Since I don't want to end up into a cycle of iterations with this I can
at this point drop the patch, unless better suggestions are available.
I.e., I'll update PR one more time dropping this patch.
We can revisit this during rc cycles. I'll hold on for a while before
taking action in order to leave a bit window to respond. Just need to
address this quickly, that's all.
BR, Jarkko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [linux-next:master 12420/13171] include/linux/compiler_types.h:602:45: error: call to '__compiletime_assert_293' declared with attribute error: min(burstcnt, len - count - 1) signedness error
2025-12-01 14:26 ` Jarkko Sakkinen
@ 2025-12-01 14:27 ` Jarkko Sakkinen
2025-12-01 16:12 ` David Laight
1 sibling, 0 replies; 6+ messages in thread
From: Jarkko Sakkinen @ 2025-12-01 14:27 UTC (permalink / raw)
To: David Laight; +Cc: kernel test robot, oe-kbuild-all, Linus Torvalds
On Mon, Dec 01, 2025 at 04:26:26PM +0200, Jarkko Sakkinen wrote:
> On Mon, Dec 01, 2025 at 12:42:56PM +0000, David Laight wrote:
> > On Mon, 1 Dec 2025 20:18:45 +0800
> > kernel test robot <lkp@intel.com> wrote:
> >
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > > head: 95cb2fd6ce0ad61af54191fe5ef271d7177f9c3a
> > > commit: 9ce4f8e56bd2ed2bd473572bbd4c1a7f8863487c [12420/13171] drivers/char/tpm: use min() instead of min_t()
> > > config: xtensa-randconfig-r123-20251201 (https://download.01.org/0day-ci/archive/20251201/202512012040.BkoYgkkr-lkp@intel.com/config)
> > > compiler: xtensa-linux-gcc (GCC) 11.5.0
> > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251201/202512012040.BkoYgkkr-lkp@intel.com/reproduce)
> > >
> > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > the same patch/commit), kindly add following tags
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202512012040.BkoYgkkr-lkp@intel.com/
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > > In file included from <command-line>:
> > > drivers/char/tpm/tpm_tis_core.c: In function 'tpm_tis_send_data':
> > > >> include/linux/compiler_types.h:602:45: error: call to '__compiletime_assert_293' declared with attribute error: min(burstcnt, len - count - 1) signedness error
> > ...
> > > drivers/char/tpm/tpm_tis_core.c:456:28: note: in expansion of macro 'min'
> > > 456 | burstcnt = min(burstcnt, len - count - 1);
> >
> > I hate compiler differences.
> > Usually the:
> > if (burstcnt < 0) {
> > ...
> > goto out_err;
> > }
> > a few lines higher is enough to make the statically_true(burstcnt >= 0) pass.
> >
> > I'm not sure why it doesn't here.
> >
> > David
>
> It is already part of PR, which I've revised already once in order to
> drop one patch:
>
> https://lore.kernel.org/linux-integrity/aSnQZ4pRWqJai6FW@kernel.org/T/#u
>
> Since I don't want to end up into a cycle of iterations with this I can
> at this point drop the patch, unless better suggestions are available.
>
> I.e., I'll update PR one more time dropping this patch.
>
> We can revisit this during rc cycles. I'll hold on for a while before
> taking action in order to leave a bit window to respond. Just need to
> address this quickly, that's all.
I did try to see if I could reproduce the compilation issue but
unfortunately Debian does not have a per-compiled toolchain for
xtensa so feels like a huge stretch to do anythin (quickly).
BR, Jarkko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [linux-next:master 12420/13171] include/linux/compiler_types.h:602:45: error: call to '__compiletime_assert_293' declared with attribute error: min(burstcnt, len - count - 1) signedness error
2025-12-01 14:26 ` Jarkko Sakkinen
2025-12-01 14:27 ` Jarkko Sakkinen
@ 2025-12-01 16:12 ` David Laight
2025-12-01 18:35 ` Jarkko Sakkinen
1 sibling, 1 reply; 6+ messages in thread
From: David Laight @ 2025-12-01 16:12 UTC (permalink / raw)
To: Jarkko Sakkinen; +Cc: kernel test robot, oe-kbuild-all, Linus Torvalds
On Mon, 1 Dec 2025 16:26:22 +0200
Jarkko Sakkinen <jarkko@kernel.org> wrote:
> On Mon, Dec 01, 2025 at 12:42:56PM +0000, David Laight wrote:
> > On Mon, 1 Dec 2025 20:18:45 +0800
> > kernel test robot <lkp@intel.com> wrote:
> >
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > > head: 95cb2fd6ce0ad61af54191fe5ef271d7177f9c3a
> > > commit: 9ce4f8e56bd2ed2bd473572bbd4c1a7f8863487c [12420/13171] drivers/char/tpm: use min() instead of min_t()
> > > config: xtensa-randconfig-r123-20251201 (https://download.01.org/0day-ci/archive/20251201/202512012040.BkoYgkkr-lkp@intel.com/config)
> > > compiler: xtensa-linux-gcc (GCC) 11.5.0
> > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251201/202512012040.BkoYgkkr-lkp@intel.com/reproduce)
> > >
> > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > the same patch/commit), kindly add following tags
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202512012040.BkoYgkkr-lkp@intel.com/
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > > In file included from <command-line>:
> > > drivers/char/tpm/tpm_tis_core.c: In function 'tpm_tis_send_data':
> > > >> include/linux/compiler_types.h:602:45: error: call to '__compiletime_assert_293' declared with attribute error: min(burstcnt, len - count - 1) signedness error
> > ...
> > > drivers/char/tpm/tpm_tis_core.c:456:28: note: in expansion of macro 'min'
> > > 456 | burstcnt = min(burstcnt, len - count - 1);
> >
> > I hate compiler differences.
> > Usually the:
> > if (burstcnt < 0) {
> > ...
> > goto out_err;
> > }
> > a few lines higher is enough to make the statically_true(burstcnt >= 0) pass.
> >
> > I'm not sure why it doesn't here.
> >
> > David
>
> It is already part of PR, which I've revised already once in order to
> drop one patch:
>
> https://lore.kernel.org/linux-integrity/aSnQZ4pRWqJai6FW@kernel.org/T/#u
>
> Since I don't want to end up into a cycle of iterations with this I can
> at this point drop the patch, unless better suggestions are available.
>
> I.e., I'll update PR one more time dropping this patch.
>
> We can revisit this during rc cycles. I'll hold on for a while before
> taking action in order to leave a bit window to respond. Just need to
> address this quickly, that's all.
I need to go through that patch set (it hit 223 patches for allmodconfig)
after the merge window and decide what to do with it.
There are a few real bugs in there where the min_t() cast does discard
significant high bits.
The pattern that failed here works most of the time.
David
>
> BR, Jarkko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [linux-next:master 12420/13171] include/linux/compiler_types.h:602:45: error: call to '__compiletime_assert_293' declared with attribute error: min(burstcnt, len - count - 1) signedness error
2025-12-01 16:12 ` David Laight
@ 2025-12-01 18:35 ` Jarkko Sakkinen
0 siblings, 0 replies; 6+ messages in thread
From: Jarkko Sakkinen @ 2025-12-01 18:35 UTC (permalink / raw)
To: David Laight; +Cc: kernel test robot, oe-kbuild-all, Linus Torvalds
On Mon, Dec 01, 2025 at 04:12:28PM +0000, David Laight wrote:
> On Mon, 1 Dec 2025 16:26:22 +0200
> Jarkko Sakkinen <jarkko@kernel.org> wrote:
>
> > On Mon, Dec 01, 2025 at 12:42:56PM +0000, David Laight wrote:
> > > On Mon, 1 Dec 2025 20:18:45 +0800
> > > kernel test robot <lkp@intel.com> wrote:
> > >
> > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > > > head: 95cb2fd6ce0ad61af54191fe5ef271d7177f9c3a
> > > > commit: 9ce4f8e56bd2ed2bd473572bbd4c1a7f8863487c [12420/13171] drivers/char/tpm: use min() instead of min_t()
> > > > config: xtensa-randconfig-r123-20251201 (https://download.01.org/0day-ci/archive/20251201/202512012040.BkoYgkkr-lkp@intel.com/config)
> > > > compiler: xtensa-linux-gcc (GCC) 11.5.0
> > > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251201/202512012040.BkoYgkkr-lkp@intel.com/reproduce)
> > > >
> > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > > the same patch/commit), kindly add following tags
> > > > | Reported-by: kernel test robot <lkp@intel.com>
> > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202512012040.BkoYgkkr-lkp@intel.com/
> > > >
> > > > All errors (new ones prefixed by >>):
> > > >
> > > > In file included from <command-line>:
> > > > drivers/char/tpm/tpm_tis_core.c: In function 'tpm_tis_send_data':
> > > > >> include/linux/compiler_types.h:602:45: error: call to '__compiletime_assert_293' declared with attribute error: min(burstcnt, len - count - 1) signedness error
> > > ...
> > > > drivers/char/tpm/tpm_tis_core.c:456:28: note: in expansion of macro 'min'
> > > > 456 | burstcnt = min(burstcnt, len - count - 1);
> > >
> > > I hate compiler differences.
> > > Usually the:
> > > if (burstcnt < 0) {
> > > ...
> > > goto out_err;
> > > }
> > > a few lines higher is enough to make the statically_true(burstcnt >= 0) pass.
> > >
> > > I'm not sure why it doesn't here.
> > >
> > > David
> >
> > It is already part of PR, which I've revised already once in order to
> > drop one patch:
> >
> > https://lore.kernel.org/linux-integrity/aSnQZ4pRWqJai6FW@kernel.org/T/#u
> >
> > Since I don't want to end up into a cycle of iterations with this I can
> > at this point drop the patch, unless better suggestions are available.
> >
> > I.e., I'll update PR one more time dropping this patch.
> >
> > We can revisit this during rc cycles. I'll hold on for a while before
> > taking action in order to leave a bit window to respond. Just need to
> > address this quickly, that's all.
>
> I need to go through that patch set (it hit 223 patches for allmodconfig)
> after the merge window and decide what to do with it.
> There are a few real bugs in there where the min_t() cast does discard
> significant high bits.
>
> The pattern that failed here works most of the time.
OK, yeah, this was what I suspected actually :-)
I just wanted to communicate what I'm about to do before I do it,
and appreciate the quick response, thanks.
I'll create +1 iteration of my pull request and drop this commit
from my master and next branches.
BR, Jarkko
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-12-01 18:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-01 12:18 [linux-next:master 12420/13171] include/linux/compiler_types.h:602:45: error: call to '__compiletime_assert_293' declared with attribute error: min(burstcnt, len - count - 1) signedness error kernel test robot
2025-12-01 12:42 ` David Laight
2025-12-01 14:26 ` Jarkko Sakkinen
2025-12-01 14:27 ` Jarkko Sakkinen
2025-12-01 16:12 ` David Laight
2025-12-01 18:35 ` Jarkko Sakkinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.