All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Hamza Mahfooz <hamzamahfooz@linux.microsoft.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next] netfilter: nf_tables: avoid chain re-validation if possible
Date: Mon, 1 Dec 2025 22:57:58 +0100	[thread overview]
Message-ID: <aS4PZsEfUC3mJZYD@strlen.de> (raw)
In-Reply-To: <20251201194829.GA8476@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>

Hamza Mahfooz <hamzamahfooz@linux.microsoft.com> wrote:
> On Sat, Nov 29, 2025 at 02:32:15AM +0100, Florian Westphal wrote:
> > I'll resubmit in a few weeks when -next opens up again.
> 
> Makes sense, in any case this patch significantly reduces the soft
> lockup rate, so feel free to add:
> 
> Tested-by: Hamza Mahfooz <hamzamahfooz@linux.microsoft.com>

Thanks for testing!

Now that you mention this: you could try to revert
314c82841602 ("netfilter: nf_tables: can't schedule in nft_chain_validate")
to get rid of all softlockup warnings:

As of a60a5abe19d6 ("netfilter: nf_tables: allow iter callbacks to sleep")
the iterator-cant-schedule no longer applies.

If i'm right you could submit a bug fix revert for nf tree.

Thanks!

      reply	other threads:[~2025-12-01 21:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-26 11:47 [PATCH nf-next] netfilter: nf_tables: avoid chain re-validation if possible Florian Westphal
2025-11-29  1:22 ` Hamza Mahfooz
2025-11-29  1:32   ` Florian Westphal
2025-12-01 19:48     ` Hamza Mahfooz
2025-12-01 21:57       ` Florian Westphal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aS4PZsEfUC3mJZYD@strlen.de \
    --to=fw@strlen.de \
    --cc=hamzamahfooz@linux.microsoft.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.