From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: jaeyoon.jung@lge.com
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization] [PATCH] irqbalance: fix build with musl
Date: Mon, 1 Dec 2025 23:43:53 -0500 [thread overview]
Message-ID: <aS5uifQnsbkA5GNS@gmail.com> (raw)
In-Reply-To: <20251126042241.3881019-1-jaeyoon.jung@lge.com>
Rather than do this backport, I completed the long overdue update
to irqbalance that should already contain this patch.
There were quite a few adjustments needed, so I haven't pushed
this to master yet.
You can see the RFC version of the update on master-next.
Bruce
In message: [meta-virtualization] [PATCH] irqbalance: fix build with musl
on 26/11/2025 Jaeyoon Jung (LGE) via lists.yoctoproject.org wrote:
> From: Jaeyoon Jung <jaeyoon.jung@lge.com>
>
> Signed-off-by: Jaeyoon Jung <jaeyoon.jung@lge.com>
> ---
> ...fix-initialisation-of-regex_t-struct.patch | 36 +++++++++++++++++++
> recipes-extended/irqbalance/irqbalance_git.bb | 1 +
> 2 files changed, 37 insertions(+)
> create mode 100644 recipes-extended/irqbalance/irqbalance/0002-procinterrupts-fix-initialisation-of-regex_t-struct.patch
>
> diff --git a/recipes-extended/irqbalance/irqbalance/0002-procinterrupts-fix-initialisation-of-regex_t-struct.patch b/recipes-extended/irqbalance/irqbalance/0002-procinterrupts-fix-initialisation-of-regex_t-struct.patch
> new file mode 100644
> index 00000000..993d9ad8
> --- /dev/null
> +++ b/recipes-extended/irqbalance/irqbalance/0002-procinterrupts-fix-initialisation-of-regex_t-struct.patch
> @@ -0,0 +1,36 @@
> +From d02ec54e635da8da8439d35b0523ce2b5d5dbae1 Mon Sep 17 00:00:00 2001
> +From: psykose <alice@ayaya.dev>
> +Date: Wed, 19 Apr 2023 19:31:19 +0000
> +Subject: [PATCH] procinterrupts: fix initialisation of regex_t struct
> +
> +{NULL} utilises the null pointer, but this is not valid, because null is a pointer:
> +
> +procinterrupts.c:110:29: error: initialization of 'long unsigned int' from 'void *' makes integer from pointer without a cast [-Werror=int-conversion]
> + 110 | { "eth.*" ,{NULL} ,NULL, IRQ_TYPE_LEGACY, IRQ_GBETH },
> +
> +0-initialisation should be done with '0' instead of a pointer.
> +
> +Upstream-Status: Backport [https://github.com/Irqbalance/irqbalance/commit/d02ec54e635da8da8439d35b0523ce2b5d5dbae1]
> +---
> + procinterrupts.c | 8 ++++----
> + 1 file changed, 4 insertions(+), 4 deletions(-)
> +
> +diff --git a/procinterrupts.c b/procinterrupts.c
> +index ec7a52b..dfa95c6 100644
> +--- a/procinterrupts.c
> ++++ b/procinterrupts.c
> +@@ -107,10 +107,10 @@ static void guess_arm_irq_hints(char *name, struct irq_info *info)
> + static int compiled = 0;
> + /* Note: Last entry is a catchall */
> + static struct irq_match matches[] = {
> +- { "eth.*" ,{NULL} ,NULL, IRQ_TYPE_LEGACY, IRQ_GBETH },
> +- { "[A-Z0-9]{4}[0-9a-f]{4}", {NULL} ,check_platform_device, IRQ_TYPE_LEGACY, IRQ_OTHER},
> +- { "PNP[0-9a-f]{4}", {NULL} ,check_platform_device, IRQ_TYPE_LEGACY, IRQ_OTHER},
> +- { ".*", {NULL}, NULL, IRQ_TYPE_LEGACY, IRQ_OTHER},
> ++ { "eth.*" , {0},NULL, IRQ_TYPE_LEGACY, IRQ_GBETH },
> ++ { "[A-Z0-9]{4}[0-9a-f]{4}", {0}, check_platform_device, IRQ_TYPE_LEGACY, IRQ_OTHER},
> ++ { "PNP[0-9a-f]{4}", {0}, check_platform_device, IRQ_TYPE_LEGACY, IRQ_OTHER},
> ++ { ".*", {0}, NULL, IRQ_TYPE_LEGACY, IRQ_OTHER},
> + {NULL},
> + };
> +
> diff --git a/recipes-extended/irqbalance/irqbalance_git.bb b/recipes-extended/irqbalance/irqbalance_git.bb
> index 46b8ed0f..7fdf1216 100644
> --- a/recipes-extended/irqbalance/irqbalance_git.bb
> +++ b/recipes-extended/irqbalance/irqbalance_git.bb
> @@ -11,6 +11,7 @@ SRC_URI = "git://github.com/Irqbalance/irqbalance;branch=master;protocol=https \
> file://add-initscript.patch \
> file://irqbalance-Add-status-and-reload-commands.patch \
> file://0001-add-void-to-fix-strict-prototypes.patch \
> + file://0002-procinterrupts-fix-initialisation-of-regex_t-struct.patch \
> "
>
> CFLAGS += "-Wno-error=format-security"
> --
> 2.47.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9457): https://lists.yoctoproject.org/g/meta-virtualization/message/9457
> Mute This Topic: https://lists.yoctoproject.org/mt/116481013/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
prev parent reply other threads:[~2025-12-02 4:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 4:22 [PATCH] irqbalance: fix build with musl jaeyoon.jung
2025-12-02 4:43 ` Bruce Ashfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aS5uifQnsbkA5GNS@gmail.com \
--to=bruce.ashfield@gmail.com \
--cc=jaeyoon.jung@lge.com \
--cc=meta-virtualization@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.