From: Ming Lei <ming.lei@redhat.com>
To: Cong Zhang <cong.zhang@oss.qualcomm.com>
Cc: Jens Axboe <axboe@kernel.dk>, Daniel Wagner <dwagner@suse.de>,
Hannes Reinecke <hare@suse.de>,
linux-arm-msm@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, pavan.kondeti@oss.qualcomm.com
Subject: Re: [PATCH] blk-mq: Abort suspend when wakeup events are pending
Date: Tue, 2 Dec 2025 17:20:32 +0800 [thread overview]
Message-ID: <aS6vYCg2Gks2BGHn@fedora> (raw)
In-Reply-To: <20251202-blkmq_skip_waiting-v1-1-f73d8a977ce0@oss.qualcomm.com>
On Tue, Dec 02, 2025 at 11:56:12AM +0800, Cong Zhang wrote:
> During system suspend, wakeup capable IRQs for block device can be
> delayed, which can cause blk_mq_hctx_notify_offline() to hang
> indefinitely while waiting for pending request to complete.
> Skip the request waiting loop and abort suspend when wakeup events are
> pending to prevent the deadlock.
>
> Fixes: bf0beec0607d ("blk-mq: drain I/O when all CPUs in a hctx are offline")
> Signed-off-by: Cong Zhang <cong.zhang@oss.qualcomm.com>
> ---
> The issue was found during system suspend with a no_soft_reset
> virtio-blk device. Here is the detailed analysis:
> - When system suspend starts and no_soft_reset is enabled, virtio-blk
> does not call its suspend callback.
> - Some requests are dispatched and queued. After sending the virtqueue
> notifier, the kernel waits for an IRQ to complete the request.
> - The virtio-blk IRQ is wakeup-capable. When the IRQ is triggered, it
> remains pending because the device is in the suspend process.
Can you explain a bit for above point? Why does the IRQ remains pending
and not get handled?
Thanks,
Ming
next prev parent reply other threads:[~2025-12-02 9:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 3:56 [PATCH] blk-mq: Abort suspend when wakeup events are pending Cong Zhang
2025-12-02 9:20 ` Ming Lei [this message]
2025-12-02 9:48 ` Cong Zhang
2025-12-02 12:29 ` Ming Lei
2025-12-03 3:38 ` Cong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aS6vYCg2Gks2BGHn@fedora \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=cong.zhang@oss.qualcomm.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavan.kondeti@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.