From: Keith Busch <kbusch@kernel.org>
To: Eugene Korenevsky <ekorenevsky@aliyun.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] nvme: nvme_identify_ns_descs: prevent oob
Date: Tue, 2 Dec 2025 13:34:01 -0700 [thread overview]
Message-ID: <aS9NOSxJk66vu2Dj@kbusch-mbp> (raw)
In-Reply-To: <aS9MTGx6V6VacZeH@localhost.localdomain>
On Tue, Dec 02, 2025 at 11:30:04PM +0300, Eugene Korenevsky wrote:
> OK, tried to make the patch as close as possible to previous code.
> See v4.
Yep, I saw. Mostly looks good to me.
> Also, adding 'pos += len' to modified `for` makes the line longer
> than 80 symbols. However, checkpatch.pl says it is OK. Let me know
> if it should be fixed somehow (e.g. by moving 'pos += len' to the
> end of loop compound statement).
The convention for this driver is to wrap lines at 80 characters. But
don't worry about sending a new version for just that; I can fix that
when applying.
prev parent reply other threads:[~2025-12-02 20:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 19:43 [PATCH v3] nvme: nvme_identify_ns_descs: prevent oob Eugene Korenevsky
2025-12-02 0:27 ` Keith Busch
2025-12-02 5:57 ` Christoph Hellwig
2025-12-02 20:30 ` Eugene Korenevsky
2025-12-02 20:34 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aS9NOSxJk66vu2Dj@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=ekorenevsky@aliyun.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.