From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5313258EFC for ; Fri, 21 Nov 2025 13:22:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763731374; cv=none; b=O4rDAvmxp7s5tSoUvDS8KASbLWCOD+GdXpsnSrLiQ0EI26Hk85CEWmt+r5YeIaZG+ni4dkNwBHX8k0XEjsUHOuOT9wA1AFcemfDuldRG+AqoqrvGRb7wE3+QB1JmsU+hFXvlSAl0NPvqWQnD2qXGWwyUX3hBv2GNJW2ma1+qrJM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763731374; c=relaxed/simple; bh=kwWIXcKz+wkJQIb8kfPn6QFbAA4BP4+5X4O3otodBWE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BUrHbQmqdGzcMhZd+Fri0s/Ee08SqtPMp2HraUskl/Q60UINyQkfxFqlMFqPC59Nwcft+kvGg4Pffusv0mz07mgoiBgjxzCOa8dZg+7lBV8wF3XHblrkLlXFm08X9S2gReVWud//tGMMtbWxKfPyWR2ggmwu0sOM0m6kQGdJao4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=il38GDHD; arc=none smtp.client-ip=209.85.128.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="il38GDHD" Received: by mail-wm1-f68.google.com with SMTP id 5b1f17b1804b1-47778b23f64so11610575e9.0 for ; Fri, 21 Nov 2025 05:22:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763731371; x=1764336171; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8QpSFXioSjyQXcU8SaMiFAt7l2VJ/I1C0RiE/RYFihE=; b=il38GDHDOAbp6gofZ4QLP7vkg+jm0onWHsGApcQZCSdDbG0Nv0GSon0fCqCTv/E0QL zHttMlD1pbLI0cCTDp+DpshB3ZTyOgN2DutylyLXbJNkqWkD2moQ/UvVU0Bra7e9ZQtG tfRKa723qrY/mhZD4dIJh7CIlBRbAY6CPpyzEqnQrcVyv0ejCpAbahAie9UHv5CEzju6 ZYUAtitwfAoR6zfGVBkAp6NcxkmPcHK9ndKilcIXSFZ4i87eXLrJDoVfQQgtyBbf3T+r A5mDIidbsqyrroVmDZPJmH6CQ4qI0BVPS7dYKUpirLF2t9Cvk0Nf0u9QuV3FAr/DkxVw gIkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763731371; x=1764336171; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8QpSFXioSjyQXcU8SaMiFAt7l2VJ/I1C0RiE/RYFihE=; b=XX1U3LVQe900gDzEoHsVvS16g7oBRRsEMh2+qewhwyhCmUhMeDnWdppV4yE47GiC3n o1vLXtBMn5l4EJxZX0dG/pUWbWs8QBWto1VtHFKlxXVWLknJOxKPtYUQEhRqCb2VrAi9 xXJ14PkWZtKi+izUQwVbWmJDKd6ozi/47ANrtpFmw8upt64QQtsjtBqELdyvcEkEotLN fEnm+JDORCyKIu6tvdek6klHo7FcRSZLxpSAJNYwSZEqzcyMBwrRg7Me1ZrksQ/SNkqX MCg9TWyzybCfb+A66vcxM/I4ivzErcaKGyq86Ay0M431ZgaIav9K71KbLVA1ysMJGkVV Go6Q== X-Forwarded-Encrypted: i=1; AJvYcCWD4ipt+Ob9fpmIwhUOsG7/Cx0LfDtMqAfwIKJFHTq/6dyD/N1rKZkBtCTV5jrSwmyBx3/EjDD1x7h5IjCV@vger.kernel.org X-Gm-Message-State: AOJu0YwunVYlo1HAowcbTk6i12Tiehw5xLDJizLOJMk8DFckXw8qb7m0 V8HAARCDsN7Q0yYRmRv4YKCU5svc8an9b/9ar6BjyclGHqF0nBh1rT50WBXRbswUo4g= X-Gm-Gg: ASbGncsWdRXDhwdBCIxU/MTiM3hItS9QSY1DR3NPEkRYljUy53Bffr7oxFLMZqvYcWR X4kYy991XZafAOB5U30uEGVBUzBVCJO4eCx8Ec9fNbE+7RduSOnic49S9JHkWpo2ErC/ir9HPtl WBzLEEEPW3wk7HZUa0s0Esg2xA9hcdEVvBxHNX3bVHhk39Xy2bGKdSSoqBqF56IcxBs6i3oSJoL x4fk8eAUsL/jBgOH84PLJQEBna3Vt2F0k73i2SwaOq+Zg9cQjPGLeHUEkZJFqEdAd+nvzH1AUvG yEcTJgM883iBZRIMF/tLwgBy//A10imtexQ4480Edy6Z3NNJmPVGukcyLTKXC4o13uJ9IvgER95 A0Kq1fjTmDu7nZR8V0hTJFce8y/a926SBrg6T5hg+hQNsCrCHp+OcmBNCu2DhQjDi1D4jrdFujG CMmGHKIEIvnT4bUJRSwfqrNQ== X-Google-Smtp-Source: AGHT+IHENEs1jPAAH0HGBykRBKQ08scGb3hNuXygpTUnmtkh54mkVXduB7RwTrk1Hwk0+hw6GdCMyg== X-Received: by 2002:a05:600c:c492:b0:477:429b:3b93 with SMTP id 5b1f17b1804b1-477c1143089mr21426265e9.18.1763731370957; Fri, 21 Nov 2025 05:22:50 -0800 (PST) Received: from linaro.org ([2a02:2454:ff23:4430:ca2:42d7:6571:757c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477a9739964sm89119435e9.1.2025.11.21.05.22.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 05:22:50 -0800 (PST) Date: Fri, 21 Nov 2025 14:22:46 +0100 From: Stephan Gerhold To: Dmitry Baryshkov Cc: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: qcom: venus: flip the venus/iris switch Message-ID: References: <20251119-venus-iris-flip-switch-v1-1-852369f66e36@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251119-venus-iris-flip-switch-v1-1-852369f66e36@oss.qualcomm.com> On Wed, Nov 19, 2025 at 05:18:18PM +0200, Dmitry Baryshkov wrote: > With the Iris and Venus driver having more or less feature parity for > "HFI 6xx" platforms and with Iris gaining support for SC7280, flip the > switch. Use Iris by default for SM8250 and SC7280, the platforms which > are supported by both drivers, and use Venus only if Iris is not > compiled at all. Use IS_ENABLED to strip out the code and data > structures which are used by the disabled platforms. > > Signed-off-by: Dmitry Baryshkov I think this will break the ChromeOS SC7280 platform, because the new Iris driver does not (yet) support the non-PAS/TZ startup sequence. Given that this is a dead (never released) platform, it probably does not make sense blocking the switch from Venus to Iris, but it should be made clear in the commit message at least. And perhaps the affected DTs should be changed to disable Venus/Iris then. It would be easy to add support for the non-PAS/TZ startup sequence in the Iris driver. The changes exist already [1], they are just stuck on the never ending discussion about how to model the additional video-firmware IOMMU entry in the DT for newer platforms [2]. Perhaps the existing legacy usage in SC7280 would be enough precedent to land this patch as-is, although I don't have access to any SC7280-based board for testing. Thanks, Stephan [1]: https://git.codelinaro.org/stephan.gerhold/linux/-/commit/14db4bfae9279a0e69a0a9d2ccdd684658916431 [2]: https://lore.kernel.org/r/20250823155349.22344-2-krzysztof.kozlowski@linaro.org/