From: Dan Carpenter <dan.carpenter@linaro.org>
To: Aaron Kling <webgeek1234@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Dan Carpenter <dan.carpenter@linaro.org>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH next] memory: tegra210-emc: Fix error codes in tegra210_emc_opp_table_init()
Date: Fri, 21 Nov 2025 16:36:08 +0300 [thread overview]
Message-ID: <aSBqyISKPN5TWbGu@stanley.mountain> (raw)
Fix several error paths where the error code was not set correctly.
Fixes: b33c93babead ("memory: tegra210: Support interconnect framework")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/memory/tegra/tegra210-emc-core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/memory/tegra/tegra210-emc-core.c b/drivers/memory/tegra/tegra210-emc-core.c
index 397448cb472d..c97ce799d53d 100644
--- a/drivers/memory/tegra/tegra210-emc-core.c
+++ b/drivers/memory/tegra/tegra210-emc-core.c
@@ -1981,11 +1981,13 @@ static int tegra210_emc_opp_table_init(struct tegra210_emc *emc)
max_opps = dev_pm_opp_get_opp_count(emc->dev);
if (max_opps <= 0) {
+ err = max_opps ?: -EINVAL;
dev_err_probe(emc->dev, err, "Failed to add OPPs\n");
goto remove_table;
}
if (emc->num_timings != max_opps) {
+ err = -EINVAL;
dev_err_probe(emc->dev, err, "OPP table does not match emc table\n");
goto remove_table;
}
@@ -1994,6 +1996,7 @@ static int tegra210_emc_opp_table_init(struct tegra210_emc *emc)
rate = emc->timings[i].rate * 1000;
opp = dev_pm_opp_find_freq_exact(emc->dev, rate, true);
if (IS_ERR(opp)) {
+ err = PTR_ERR(opp);
dev_err_probe(emc->dev, err, "Rate %lu not found in OPP table\n", rate);
goto remove_table;
}
--
2.51.0
reply other threads:[~2025-11-21 13:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSBqyISKPN5TWbGu@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=webgeek1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.