From: Bobby Eshleman <bobbyeshleman@gmail.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
"Haiyang Zhang" <haiyangz@microsoft.com>,
"Wei Liu" <wei.liu@kernel.org>,
"Dexuan Cui" <decui@microsoft.com>,
"Bryan Tan" <bryan-bt.tan@broadcom.com>,
"Vishnu Dasa" <vishnu.dasa@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Shuah Khan" <shuah@kernel.org>,
linux-kernel@vger.kernel.org, virtualization@lists.linux.dev,
netdev@vger.kernel.org, kvm@vger.kernel.org,
linux-hyperv@vger.kernel.org, linux-kselftest@vger.kernel.org,
berrange@redhat.com, "Sargun Dhillon" <sargun@sargun.me>,
"Bobby Eshleman" <bobbyeshleman@meta.com>
Subject: Re: [PATCH net-next v11 05/13] vsock: add netns support to virtio transports
Date: Fri, 21 Nov 2025 11:03:51 -0800 [thread overview]
Message-ID: <aSC3lwPvj0G6L8Sh@devvm11784.nha0.facebook.com> (raw)
In-Reply-To: <v6dpp4j4pjnrsa5amw7uubbqtpnxb4odpjhyjksr4mqes2qbzg@3bsjx5ofbwl4>
On Fri, Nov 21, 2025 at 03:39:25PM +0100, Stefano Garzarella wrote:
> On Thu, Nov 20, 2025 at 09:44:37PM -0800, Bobby Eshleman wrote:
> > From: Bobby Eshleman <bobbyeshleman@meta.com>
> >
> > Add netns support to loopback and vhost. Keep netns disabled for
> > virtio-vsock, but add necessary changes to comply with common API
> > updates.
> >
> > This is the patch in the series when vhost-vsock namespaces actually
> > come online. Hence, vhost_transport_supports_local_mode() is switched
> > to return true.
> >
> > Signed-off-by: Bobby Eshleman <bobbyeshleman@meta.com>
> > ---
> > Changes in v11:
> > - reorder with the skb ownership patch for loopback (Stefano)
> > - toggle vhost_transport_supports_local_mode() to true
> >
> > Changes in v10:
> > - Splitting patches complicates the series with meaningless placeholder
> > values that eventually get replaced anyway, so to avoid that this
> > patch combines into one. Links to previous patches here:
> > - Link: https://lore.kernel.org/all/20251111-vsock-vmtest-v9-3-852787a37bed@meta.com/
> > - Link: https://lore.kernel.org/all/20251111-vsock-vmtest-v9-6-852787a37bed@meta.com/
> > - Link: https://lore.kernel.org/all/20251111-vsock-vmtest-v9-7-852787a37bed@meta.com/
> > - remove placeholder values (Stefano)
> > - update comment describe net/net_mode for
> > virtio_transport_reset_no_sock()
> > ---
> > drivers/vhost/vsock.c | 47 ++++++++++++++++++------
> > include/linux/virtio_vsock.h | 8 +++--
> > net/vmw_vsock/virtio_transport.c | 10 ++++--
> > net/vmw_vsock/virtio_transport_common.c | 63 ++++++++++++++++++++++++---------
> > net/vmw_vsock/vsock_loopback.c | 8 +++--
> > 5 files changed, 103 insertions(+), 33 deletions(-)
>
> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
If we move the supports_local_mode() changes into this patch (for virtio
and loopback, as I bring up in other discussion), should I drop this
trailer or carry it forward?
Thanks,
Bobby
next prev parent reply other threads:[~2025-11-21 19:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 5:44 [PATCH net-next v11 00/13] vsock: add namespace support to vhost-vsock and loopback Bobby Eshleman
2025-11-21 5:44 ` [PATCH net-next v11 01/13] vsock: a per-net vsock NS mode state Bobby Eshleman
2025-11-21 5:44 ` [PATCH net-next v11 02/13] vsock: add netns to vsock core Bobby Eshleman
2025-11-21 5:44 ` [PATCH net-next v11 03/13] vsock: reject bad VSOCK_NET_MODE_LOCAL configuration for G2H Bobby Eshleman
2025-11-21 14:24 ` Stefano Garzarella
2025-11-21 19:01 ` Bobby Eshleman
2025-11-24 10:10 ` Stefano Garzarella
2025-11-24 17:29 ` Bobby Eshleman
2025-11-24 17:54 ` Stefano Garzarella
2025-11-24 18:25 ` Bobby Eshleman
2025-11-25 9:24 ` Stefano Garzarella
2025-11-21 5:44 ` [PATCH net-next v11 04/13] virtio: set skb owner of virtio_transport_reset_no_sock() reply Bobby Eshleman
2025-11-21 14:24 ` Stefano Garzarella
2025-11-21 5:44 ` [PATCH net-next v11 05/13] vsock: add netns support to virtio transports Bobby Eshleman
2025-11-21 14:39 ` Stefano Garzarella
2025-11-21 19:03 ` Bobby Eshleman [this message]
2025-11-24 13:02 ` Stefano Garzarella
2025-11-21 5:44 ` [PATCH net-next v11 06/13] selftests/vsock: add namespace helpers to vmtest.sh Bobby Eshleman
2025-11-21 5:44 ` [PATCH net-next v11 07/13] selftests/vsock: prepare vm management helpers for namespaces Bobby Eshleman
2025-11-21 5:44 ` [PATCH net-next v11 08/13] selftests/vsock: add vm_dmesg_{warn,oops}_count() helpers Bobby Eshleman
2025-11-21 14:42 ` Stefano Garzarella
2025-11-21 5:44 ` [PATCH net-next v11 09/13] selftests/vsock: use ss to wait for listeners instead of /proc/net Bobby Eshleman
2025-11-21 14:43 ` Stefano Garzarella
2025-11-21 5:44 ` [PATCH net-next v11 10/13] selftests/vsock: add tests for proc sys vsock ns_mode Bobby Eshleman
2025-11-21 14:44 ` Stefano Garzarella
2025-11-21 5:44 ` [PATCH net-next v11 11/13] selftests/vsock: add namespace tests for CID collisions Bobby Eshleman
2025-11-21 14:48 ` Stefano Garzarella
2025-11-21 5:44 ` [PATCH net-next v11 12/13] selftests/vsock: add tests for host <-> vm connectivity with namespaces Bobby Eshleman
2025-11-21 14:52 ` Stefano Garzarella
2025-11-21 5:44 ` [PATCH net-next v11 13/13] selftests/vsock: add tests for namespace deletion and mode changes Bobby Eshleman
2025-11-21 14:53 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSC3lwPvj0G6L8Sh@devvm11784.nha0.facebook.com \
--to=bobbyeshleman@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=berrange@redhat.com \
--cc=bobbyeshleman@meta.com \
--cc=bryan-bt.tan@broadcom.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=haiyangz@microsoft.com \
--cc=horms@kernel.org \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sargun@sargun.me \
--cc=sgarzare@redhat.com \
--cc=shuah@kernel.org \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=vishnu.dasa@broadcom.com \
--cc=wei.liu@kernel.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.