All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Sherry Sun <sherry.sun@nxp.com>, Jacky Bai <ping.bai@nxp.com>,
	Jon Hunter <jonathanh@nvidia.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Derek Barbosa <debarbos@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH printk v1] printk: Avoid irq_work for printk_deferred() on suspend
Date: Fri, 21 Nov 2025 17:07:35 +0100	[thread overview]
Message-ID: <aSCOR56F8zbgzDHs@pathway.suse.cz> (raw)
In-Reply-To: <20251121102010.359369-1-john.ogness@linutronix.de>

On Fri 2025-11-21 11:26:00, John Ogness wrote:
> With commit ("printk: Avoid scheduling irq_work on suspend") the
> implementation of printk_get_console_flush_type() was modified to
> avoid offloading when irq_work should be blocked during suspend.
> Since printk uses the returned flush type to determine what
> flushing methods are used, this was thought to be sufficient for
> avoiding irq_work usage during the suspend phase.
> 
> However, vprintk_emit() implements a hack to support
> printk_deferred(). In this hack, the returned flush type is
> adjusted to make sure no legacy direct printing occurs when
> printk_deferred() was used.
> 
> Because of this hack, the legacy offloading flushing method can
> still be used, causing irq_work to be queued when it should not
> be.
> 
> Adjust the vprintk_emit() hack to also consider
> @console_irqwork_blocked so that legacy offloading will not be
> chosen when irq_work should be blocked.
> 
> Link: https://lore.kernel.org/lkml/87fra90xv4.fsf@jogness.linutronix.de
> Signed-off-by: John Ogness <john.ogness@linutronix.de>

JFYI, the patch has been committed into printk/linux.git,
branch rework/suspend-fixes.

Best Regards,
Petr

      parent reply	other threads:[~2025-11-21 16:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-21 10:20 [PATCH printk v1] printk: Avoid irq_work for printk_deferred() on suspend John Ogness
2025-11-21 15:55 ` Petr Mladek
2025-11-21 16:07 ` Petr Mladek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aSCOR56F8zbgzDHs@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=debarbos@redhat.com \
    --cc=john.ogness@linutronix.de \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ping.bai@nxp.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --cc=sherry.sun@nxp.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.