From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: "Qipeng Zha" <qipeng.zha@intel.com>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Darren Hart" <dvhart@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] platform/x86: intel: punit_ipc: fix memory corruption
Date: Mon, 24 Nov 2025 09:17:40 +0200 [thread overview]
Message-ID: <aSQGlLXYTWzus5e-@smile.fi.intel.com> (raw)
In-Reply-To: <aSBqXtt8hJb7WYIc@stanley.mountain>
On Fri, Nov 21, 2025 at 04:34:22PM +0300, Dan Carpenter wrote:
> This passes a stack address to the IRQ handler, "&punit_ipcdev" vs
> "punit_ipcdev" without the ampersand. This means that the:
>
> complete(&ipcdev->cmd_complete);
>
> in intel_punit_ioc() will corrupt the wrong memory.
Good catch, now the question, how this driver was ever tested?..
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-11-24 7:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 13:34 [PATCH] platform/x86: intel: punit_ipc: fix memory corruption Dan Carpenter
2025-11-21 17:27 ` Ilpo Järvinen
2025-11-21 17:51 ` Dan Carpenter
2025-11-24 7:17 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSQGlLXYTWzus5e-@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dan.carpenter@linaro.org \
--cc=dvhart@linux.intel.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qipeng.zha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.