From: Cyril Hrubis <chrubis@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] shell: Add support for runtime
Date: Mon, 24 Nov 2025 13:23:34 +0100 [thread overview]
Message-ID: <aSRORpbkcvMkIkQt@yuki.lan> (raw)
In-Reply-To: <CAEemH2f87qUSNZ0u5uFBPeZ=DrZLjcvtGFGZGzvpgwhzeaVuSA@mail.gmail.com>
Hi!
> Do we need to add a flexible TIMEOUT in shell support as well?
Well I guess that we will need timeout in the shell library eventually
as well, however for this patch I'm trying to keep the changes minimal
since threre is a test that needs this already.
> The default TST_TIMEOUT in SHELL is 300, which is not consistent with C
> method (DEFAULT_TIMEOUT + tst_test->timeout).
As explained by Peter the shell library with the C library loader has
exactly the same logic for runtime and timeout.
> Anyway, this patch itself looks good:
> Reviewed-by: Li Wang <liwang@redhat.com>
Pushed, thanks.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2025-11-24 12:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 9:31 [LTP] [PATCH] shell: Add support for runtime Cyril Hrubis
2025-11-20 7:32 ` Li Wang via ltp
2025-11-20 13:33 ` Petr Vorel
2025-11-24 12:23 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSRORpbkcvMkIkQt@yuki.lan \
--to=chrubis@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.