From: Christoph Hellwig <hch@infradead.org>
To: John Garry <john.g.garry@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
alexjlzheng@gmail.com, cem@kernel.org, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jinliang Zheng <alexjlzheng@tencent.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>
Subject: Re: [PATCH] xfs: fix confused tracepoints in xfs_reflink_end_atomic_cow()
Date: Mon, 24 Nov 2025 06:04:56 -0800 [thread overview]
Message-ID: <aSRmCPKBOpSaAYYN@infradead.org> (raw)
In-Reply-To: <93b2420b-0bd8-4591-83eb-8976afec4550@oracle.com>
On Mon, Nov 24, 2025 at 10:57:24AM +0000, John Garry wrote:
> Commit d6f215f35963 might be able to explain that.
I don't think so. That commit splits up the operation so to avoid
doing the entire operation in a single transaction, and the rationale
for this is sound. But the atomic work showed that it went to far,
because we can still batch up a fair amount of conversions. I think
the argument of allowing to batch up as many transactions as we allow
in an atomic write still makes perfect sense.
next prev parent reply other threads:[~2025-11-24 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 11:56 [PATCH] xfs: fix confused tracepoints in xfs_reflink_end_atomic_cow() alexjlzheng
2025-11-24 9:34 ` Christoph Hellwig
2025-11-24 10:57 ` John Garry
2025-11-24 14:04 ` Christoph Hellwig [this message]
2025-11-24 14:25 ` John Garry
2025-11-25 2:18 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSRmCPKBOpSaAYYN@infradead.org \
--to=hch@infradead.org \
--cc=alexjlzheng@gmail.com \
--cc=alexjlzheng@tencent.com \
--cc=cem@kernel.org \
--cc=darrick.wong@oracle.com \
--cc=john.g.garry@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.