Re: [Buildroot] [PATCH 1/1] package/libconfig: refresh tarball hash

[yann.morin@orange.com]

Florian, All,

On 2025-11-24 15:06 +0100, Florian Larysch spake thusly:
> Upstream has modified the release tarball without bumping the version,
> presumably to fix [1], which is now causing build issues. Refresh the
> hash to match the new tarball.
> 
> The original version is still available on sources.buildroot.net,
> yielding the following diffstat:
> 
>  Makefile.am                 |    1 +
>  Makefile.in                 |    1 +
>  examples/c/Makefile.am      |    2 +-
>  examples/c/Makefile.in      |    2 +-
>  examples/c/pathbuf.h        |   54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  lib/libconfig++.pc.cmake.in |   12 ++++++++++++
>  lib/libconfig.pc.cmake.in   |   12 ++++++++++++
>  7 files changed, 82 insertions(+), 2 deletions(-)
> 
> Where the Makefile changes only add references to the added header and
> pkg-config files.
> 
> [1] https://github.com/hyperrealm/libconfig/issues/256
> 
> Fixes: https://autobuild.buildroot.org/results/89b/89b15ed871a7d8e2a789d1d9a1bab11b7f50274b/
> 
> Signed-off-by: Florian Larysch <fl@n621.de>
> ---
>  package/libconfig/libconfig.hash | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/libconfig/libconfig.hash b/package/libconfig/libconfig.hash
> index 2b10dfc125..42935426a8 100644
> --- a/package/libconfig/libconfig.hash
> +++ b/package/libconfig/libconfig.hash
> @@ -1,3 +1,3 @@
>  # Locally computed:
> -sha256  87c6f382994b245f9213be34a2bf19c8ee7d033d7abaa51e88fbb7bad79e2dc6  libconfig-1.8.1.tar.gz
> +sha256  c73ee3d914ec68c99b61e864832931e9a7112eeabfb449dad217fd83e385cbdf  libconfig-1.8.1.tar.gz

We can't do that.

People using older versions of Buildroot will ahve the old hash, while
those using a newer version will have the new hash.

So, if we update the archive on s.b.o, older Buildroot versions are
broken: libconfig is no longer downloadable, because no archive match
the old hash.

If we don't update, newer versions will always fallback to downloding
from s.b.o., but this is not good, as it no longer matches upstream's
archive.

In this case, either we can upsdate to a newer version (but there's none
so far), or we change to fetch from git:

    LIBCONFIG_VERSION = v1.8.1
    LIBCONFIG_SITE = https://github.com/hyperrealm/libconfig
    LIBCONFIG_SITE_METHOD = git

and update the hash file accordingly.

(we can't use the $(call github,...) helper, as the generated archive
would also be named libconfig-1.8.1.tar.gz, which would also
conflict...)

Also, bang on upstream's head and tell them : "Do not, ever, ever,
change an existing tag or release! Release a new version instead!" ;-)

Regards,
Yann E. MORIN.

>  sha256  cbbad55f94feadb16061c4f782910bac254460a44f1c8abd2b91452eff085f55  COPYING.LIB
> -- 
> 2.51.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
                                        ____________
.-----------------.--------------------:       _    :------------------.
|  Yann E. MORIN  | Real-Time Embedded |    __/ )   | /"\ ASCII RIBBON |
|                 | Software  Designer |  _/ - /'   | \ / CAMPAIGN     |
| +33 638.411.245 '--------------------: (_    `--, |  X  AGAINST      |
| yann.morin (at) orange.com           |_="    ,--' | / \ HTML MAIL    |
'--------------------------------------:______/_____:------------------'

____________________________________________________________________________________________________________
Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot