Re: [PATCH 0/2] hw/ipmi/ipmi_bmc_sim: Get/set fake LAN config

[Corey Minyard <corey@minyard.net>]

On Tue, Oct 28, 2025 at 06:01:18PM +0000, Yunpeng Yang wrote:
> Support for a fake LAN channel is added to the device `ipmi_bmc_sim`.
> Although there is no real LAN channel, some testing processes which
> require interactions with BMC LAN channel will become easier.
> 
> There's another device `ipmi_bmc_extern` which works together with some
> external BMC simulator, e.g., `ipmi_sim`. More comprehensive BMC
> simulation can be achieved with `ipmi_bmc_extern`. However,
> `ipmi_bmc_sim` is more light-weight and is built into QEMU.

I apologize for the time on this, it slipped between the cracks.

These both look good.  I can give a:

Reviewed-by: Corey Minyard <corey@minyard.net>

or 

Acked-by: Corey Minyard <corey@minyard.net>

or I can take it into my tree if you aren't bringing it in any place
else.

One thing you should try is doing a migration between a version 1 and
version 2 device, and between two version 2 devices, just to be sure
migration still works.  Assuming you haven't done this already.

-corey

> 
> Yunpeng Yang (2):
>   hw/ipmi/ipmi_bmc_sim: Support getting fake LAN channel config
>   hw/ipmi/ipmi_bmc_sim: Support setting fake LAN channel config
> 
>  hw/ipmi/ipmi_bmc_sim.c      | 407 +++++++++++++++++++++++++++++++++++-
>  include/hw/ipmi/ipmi.h      |   1 +
>  qemu-options.hx             |  26 +++
>  tests/qtest/ipmi-kcs-test.c | 143 +++++++++++++
>  4 files changed, 567 insertions(+), 10 deletions(-)
> 
> -- 
> 2.43.7
>