From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 1/8] igt: Name drmModeCrtc variables 'drm_crtc'
Date: Mon, 24 Nov 2025 23:11:42 +0200 [thread overview]
Message-ID: <aSTKDpX5hLC2bk5B@intel.com> (raw)
In-Reply-To: <2a9ad8950036a45431774a6ab66b11d65a8a041f@intel.com>
On Mon, Nov 24, 2025 at 11:37:23AM +0200, Jani Nikula wrote:
> On Fri, 21 Nov 2025, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > The current situation with pipes vs. crtcs is a giant mess.
> > In order to untangle things properly I think we need to
> > move away from the pipe stuff into a more pure crtc world.
> >
> > I suspect the best way to get there is by renaming igt_pipe_t
> > into igt_crtc_t and making everyone use it instead of the raw
> > index/pipe numbers. And presumable we'll want to call the
> > igt_crtc_t variables 'crtc', so let's clear out the namespace
> > for that by using 'drm_crtc' as the variable name for the
> > lower level drmModeCrtc stuff.
>
> For clarity, I suppose also s/crtc_offset/crtc_index/g for the member in
> igt_pipe_t (igt_crtc_t) would be in order as follow-up.
Yeah, IIRC I have that in one of my wip cocci scripts as well.
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2025-11-24 21:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 19:06 [PATCH i-g-t 0/8] kms: Small cleanups and refactoring Ville Syrjala
2025-11-21 19:06 ` [PATCH i-g-t 1/8] igt: Name drmModeCrtc variables 'drm_crtc' Ville Syrjala
2025-11-24 9:37 ` Jani Nikula
2025-11-24 21:11 ` Ville Syrjälä [this message]
2025-11-21 19:06 ` [PATCH i-g-t 2/8] lib/kms: Nuke PIPE_ANY Ville Syrjala
2025-11-24 7:25 ` Sharma, Swati2
2025-11-21 19:06 ` [PATCH i-g-t 3/8] lib/kms: Nuke unused kmstest_{crtc,plane} Ville Syrjala
2025-11-24 7:27 ` Sharma, Swati2
2025-11-21 19:06 ` [PATCH i-g-t 4/8] igt/kms: Nuke unused igt_pipe_*prop*() marcos and functions Ville Syrjala
2025-11-24 12:19 ` Sharma, Swati2
2025-11-21 19:06 ` [PATCH i-g-t 5/8] lib/kms: Turn the igt_plane*prop*() marcos into functions Ville Syrjala
2025-11-21 19:06 ` [PATCH i-g-t 6/8] lib/kms: Turn the igt_output*prop*() " Ville Syrjala
2025-11-21 19:06 ` [PATCH i-g-t 7/8] lib/kms: Turn the igt_pipe_obj*prop*() " Ville Syrjala
2025-11-21 19:06 ` [PATCH i-g-t 8/8] test/kms_color: Don't dig around in display->pipes[] so much Ville Syrjala
2025-11-24 9:34 ` [PATCH i-g-t 0/8] kms: Small cleanups and refactoring Jani Nikula
2025-11-25 5:48 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-11-25 5:52 ` ✓ i915.CI.BAT: " Patchwork
2025-11-25 8:57 ` ✗ Xe.CI.Full: failure " Patchwork
2025-11-25 12:10 ` ✗ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSTKDpX5hLC2bk5B@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.