Re: drivers/clk/microchip/clk-core.c:915:10: sparse: sparse: Initializer entry defined twice

[Brian Masney <bmasney@redhat.com>]

On Sat, Nov 22, 2025 at 09:39:06PM +0800, kernel test robot wrote:
> Hi Brian,
> 
> First bad commit (maybe != root cause):
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   2eba5e05d9bcf4cdea995ed51b0f07ba0275794a
> commit: 7d85cd8730ab7701a1cafd0db0d7b6b1f6cfbb91 clk: microchip: core: remove duplicate roclk_determine_rate()
> date:   7 weeks ago
> config: mips-randconfig-r134-20251122 (https://download.01.org/0day-ci/archive/20251122/202511222115.uvHrP95A-lkp@intel.com/config)
> compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9e9fe08b16ea2c4d9867fb4974edf2a3776d6ece)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251122/202511222115.uvHrP95A-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202511222115.uvHrP95A-lkp@intel.com/
> 
> sparse warnings: (new ones prefixed by >>)
> >> drivers/clk/microchip/clk-core.c:915:10: sparse: sparse: Initializer entry defined twice
>    drivers/clk/microchip/clk-core.c:919:10: sparse:   also defined here
> 
> vim +915 drivers/clk/microchip/clk-core.c
> 
> ce6e1188465998 Purna Chandra Mandal 2016-05-13  910  
> ce6e1188465998 Purna Chandra Mandal 2016-05-13  911  /* sclk with post-divider */
> ce6e1188465998 Purna Chandra Mandal 2016-05-13  912  const struct clk_ops pic32_sclk_ops = {
> ce6e1188465998 Purna Chandra Mandal 2016-05-13  913  	.get_parent	= sclk_get_parent,
> ce6e1188465998 Purna Chandra Mandal 2016-05-13  914  	.set_parent	= sclk_set_parent,
> e9f039c08cdc9b Brian Masney         2025-08-11 @915  	.determine_rate = sclk_determine_rate,
> ce6e1188465998 Purna Chandra Mandal 2016-05-13  916  	.set_rate	= sclk_set_rate,
> ce6e1188465998 Purna Chandra Mandal 2016-05-13  917  	.recalc_rate	= sclk_get_rate,
> ce6e1188465998 Purna Chandra Mandal 2016-05-13  918  	.init		= sclk_init,
> ce6e1188465998 Purna Chandra Mandal 2016-05-13  919  	.determine_rate = __clk_mux_determine_rate,
> ce6e1188465998 Purna Chandra Mandal 2016-05-13  920  };
> ce6e1188465998 Purna Chandra Mandal 2016-05-13  921  
> 
> :::::: The code at line 915 was first introduced by commit
> :::::: e9f039c08cdc9b38665aee9a88ae21f59c09ba8c clk: microchip: core: convert from round_rate() to determine_rate()
> 
> :::::: TO: Brian Masney <bmasney@redhat.com>
> :::::: CC: Brian Masney <bmasney@redhat.com>

Thanks for the report. I posted a fix for this:

https://lore.kernel.org/linux-clk/20251125-clk-microchip-fixes-v1-0-6c1f5573d1b9@redhat.com/T/#t

Brian