From: Alice Ryhl <aliceryhl@google.com>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Uladzislau Rezki <urezki@gmail.com>,
Vitaly Wool <vitaly.wool@konsulko.se>,
linux-mm@kvack.org
Subject: Re: [PATCH 24/46] rust: mm: add __rust_helper to helpers
Date: Wed, 3 Dec 2025 09:03:24 +0000 [thread overview]
Message-ID: <aS_83HjEgLqLm4AR@google.com> (raw)
In-Reply-To: <aS-VrkRdQc0H6nSs@tardis.local>
On Tue, Dec 02, 2025 at 05:43:10PM -0800, Boqun Feng wrote:
> On Tue, Dec 02, 2025 at 07:37:48PM +0000, Alice Ryhl wrote:
> > This is needed to inline these helpers into Rust code.
> >
> > Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> > ---
> [...]
> > --- a/rust/helpers/vmalloc.c
> > +++ b/rust/helpers/vmalloc.c
> > @@ -2,9 +2,10 @@
> >
> > #include <linux/vmalloc.h>
> >
> > -void * __must_check __realloc_size(2)
> > -rust_helper_vrealloc_node_align(const void *p, size_t size, unsigned long align,
> > - gfp_t flags, int node)
> > +__rust_helper void *__must_check __realloc_size(2)
> > + rust_helper_vrealloc_node_align(const void *p, size_t size,
>
> The indent here seems to be incorrect?
This is what I got from ClangFormat, but your suggestion does look
better, so I'll update it.
Alice
next prev parent reply other threads:[~2025-12-03 9:03 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 19:37 [PATCH 00/46] Allow inlining C helpers into Rust when using LTO Alice Ryhl
2025-12-02 19:37 ` [PATCH 01/46] rust: auxiliary: add __rust_helper to helpers Alice Ryhl
2025-12-02 19:37 ` [PATCH 02/46] rust: barrier: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 03/46] rust: binder: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 04/46] rust: bitmap: " Alice Ryhl
2025-12-15 17:08 ` Yury Norov
2025-12-02 19:37 ` [PATCH 05/46] rust: bitops: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 06/46] rust: blk: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 07/46] rust: bug: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 08/46] rust: clk: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 09/46] rust: completion: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 10/46] rust: cpu: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 11/46] rust: cpufreq: " Alice Ryhl
2025-12-03 5:48 ` Viresh Kumar
2025-12-02 19:37 ` [PATCH 12/46] rust: cpumask: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 13/46] rust: cred: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 14/46] rust: device: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 15/46] rust: dma: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 16/46] rust: drm: " Alice Ryhl
2025-12-15 21:49 ` Danilo Krummrich
2025-12-02 19:37 ` [PATCH 17/46] rust: err: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 18/46] rust: fs: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 19/46] rust: io: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 20/46] rust: irq: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 21/46] rust: jump_label: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 22/46] rust: kunit: " Alice Ryhl
2025-12-13 2:12 ` David Gow
2025-12-13 2:45 ` Alice Ryhl
2025-12-02 19:37 ` [PATCH 23/46] rust: maple_tree: " Alice Ryhl
2025-12-04 21:07 ` Andrew Ballance
2025-12-02 19:37 ` [PATCH 24/46] rust: mm: " Alice Ryhl
2025-12-03 1:43 ` Boqun Feng
2025-12-03 9:03 ` Alice Ryhl [this message]
2025-12-02 19:37 ` [PATCH 25/46] rust: of: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 26/46] rust: pci: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 27/46] rust: pid_namespace: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 28/46] rust: platform: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 29/46] rust: poll: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 30/46] rust: processor: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 31/46] rust: property: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 32/46] rust: rbtree: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 33/46] rust: rcu: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 34/46] rust: refcount: " Alice Ryhl
2025-12-02 19:37 ` [PATCH 35/46] rust: regulator: " Alice Ryhl
2025-12-02 19:38 ` [PATCH 36/46] rust: scatterlist: " Alice Ryhl
2025-12-02 19:38 ` [PATCH 37/46] rust: security: " Alice Ryhl
2025-12-02 19:38 ` [PATCH 38/46] rust: slab: " Alice Ryhl
2025-12-03 1:45 ` Boqun Feng
2025-12-03 9:03 ` Alice Ryhl
2025-12-02 19:38 ` [PATCH 39/46] rust: sync: " Alice Ryhl
2025-12-02 19:38 ` [PATCH 40/46] rust: task: " Alice Ryhl
2025-12-02 19:38 ` [PATCH 41/46] rust: time: " Alice Ryhl
2025-12-02 19:38 ` [PATCH 42/46] rust: uaccess: " Alice Ryhl
2025-12-02 19:38 ` [PATCH 43/46] rust: usb: " Alice Ryhl
2025-12-02 19:38 ` [PATCH 44/46] rust: wait: " Alice Ryhl
2025-12-02 19:38 ` [PATCH 45/46] rust: workqueue: " Alice Ryhl
2025-12-02 19:38 ` [PATCH 46/46] rust: xarray: " Alice Ryhl
2025-12-03 1:47 ` [PATCH 00/46] Allow inlining C helpers into Rust when using LTO Boqun Feng
2025-12-03 14:33 ` Gary Guo
2025-12-04 10:05 ` (subset) " Christian Brauner
2025-12-15 13:59 ` Mark Brown
2025-12-15 21:40 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aS_83HjEgLqLm4AR@google.com \
--to=aliceryhl@google.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=boqun.feng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=urezki@gmail.com \
--cc=vitaly.wool@konsulko.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.