From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>
Cc: broonie@kernel.org, tiwai@suse.com, perex@perex.cz,
amade@asmblr.net, linux-sound@vger.kernel.org
Subject: Re: [PATCH v2 2/6] ASoC: Intel: catpt: Switch to resource_xxx() API
Date: Wed, 26 Nov 2025 17:41:26 +0200 [thread overview]
Message-ID: <aScfpoia9DMW5HP_@smile.fi.intel.com> (raw)
In-Reply-To: <20251126095523.3925364-3-cezary.rojewski@intel.com>
On Wed, Nov 26, 2025 at 10:55:19AM +0100, Cezary Rojewski wrote:
> There is a number of interfaces available for manipulating instances of
> struct resource. To improve readability, move away from manual editing
> in favor of the common interface.
>
> While at it, adjust spacing so that both code blocks, while found in
> separate functions, looks cohesive.
...
> - r1.start = cdev->dram.start + blk->ram_offset;
> - r1.end = r1.start + blk->size - 1;
> + resource_set_range(&r1, cdev->dram.start + blk->ram_offset, blk->size);
+ blank line.
And strictly speaking we have resource_size(&cdev->dram).
> /* advance to data area */
> paddr += sizeof(*blk);
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-11-26 15:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 9:55 [PATCH v2 0/6] ASoC: Intel: catpt: Round of fixes and PM changes Cezary Rojewski
2025-11-26 9:55 ` [PATCH v2 1/6] ASoC: Intel: catpt: Fix offset checks Cezary Rojewski
2025-11-26 18:09 ` Andy Shevchenko
2025-11-26 9:55 ` [PATCH v2 2/6] ASoC: Intel: catpt: Switch to resource_xxx() API Cezary Rojewski
2025-11-26 15:41 ` Andy Shevchenko [this message]
2025-11-26 18:08 ` Andy Shevchenko
2025-11-26 9:55 ` [PATCH v2 3/6] ASoC: Intel: catpt: Fix error path in hw_params() Cezary Rojewski
2025-11-26 16:22 ` Andy Shevchenko
2025-11-26 9:55 ` [PATCH v2 4/6] ASoC: Intel: catpt: Fix probing order of driver components Cezary Rojewski
2025-11-26 16:22 ` Andy Shevchenko
2025-11-26 9:55 ` [PATCH v2 5/6] ASoC: Intel: catpt: Do not ignore errors on runtime resume Cezary Rojewski
2025-11-26 9:55 ` [PATCH v2 6/6] ASoC: Intel: catpt: Do not block the system from suspending Cezary Rojewski
2025-11-28 18:01 ` [PATCH v2 0/6] ASoC: Intel: catpt: Round of fixes and PM changes Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aScfpoia9DMW5HP_@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=amade@asmblr.net \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.