From: Dan Carpenter <dan.carpenter@linaro.org>
To: Tomasz Sadowski <tsdwski@gmail.com>
Cc: Dave Penkler <dpenkler@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fluke_gpib: use kzalloc instead of kmalloc + memset
Date: Wed, 26 Nov 2025 19:52:26 +0300 [thread overview]
Message-ID: <aScwSm0RoNVRj68q@stanley.mountain> (raw)
In-Reply-To: <20251126155453.45178-1-tsdwski@gmail.com>
On Wed, Nov 26, 2025 at 04:48:52PM +0100, Tomasz Sadowski wrote:
> > You did not specify a description of why the patch is needed, or
> > possibly, any description at all, in the email body. [...]
>
> Thanks, the commit message now includes a proper description.
> The patch itself has not changed.
>
> I also realized that the previous subject line might have been incorrect.
> The correct subject should be:
>
> staging: gpib: eastwood: use kzalloc instead of kmalloc + memset
>
All this is weird commentary to put into a patch...
> Use kzalloc() instead of kmalloc() + memset() to simplify memory allocation.
>
> Also use sizeof(*board->private_data) instead of repeating the struct name.
> This avoids duplication and keeps the code correct if the struct name
> changes in the future.
>
> Signed-off-by: Tomasz Sadowski <tsdwski@gmail.com>
> ---
This isn't how to send a v2 patch.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards,
dan carpenter
prev parent reply other threads:[~2025-11-26 16:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 14:03 [PATCH] staging: fluke_gpib: use kzalloc instead of kmalloc + memset Tomasz Sadowski
2025-11-26 7:32 ` Greg Kroah-Hartman
2025-11-26 15:48 ` Tomasz Sadowski
2025-11-26 16:52 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aScwSm0RoNVRj68q@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=tsdwski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.