From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Santos <Jonathan.Santos@analog.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Michael.Hennerich@analog.com,
jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, marcelo.schmitt@analog.com,
jonath4nns@gmail.com
Subject: Re: [PATCH v4 3/4] units: add BASIS_POINTS macro
Date: Thu, 27 Nov 2025 00:01:27 +0200 [thread overview]
Message-ID: <aSd4t0kln98ptofg@smile.fi.intel.com> (raw)
In-Reply-To: <6dafbe2577ba5fab28a84daf55111d9ede4a1938.1764101647.git.Jonathan.Santos@analog.com>
On Wed, Nov 26, 2025 at 06:56:26PM -0300, Jonathan Santos wrote:
> Add macro for basis points unit, defined as a 1/100th of a percent.
Fine, but why? Can you elaborate more on use cases?
...
Perhaps you also want to add a PERCENT to understand the relationship
between two?
> +#define BASIS_POINTS 10000UL
And this needs a comment with an example (something like I asked above
for the commit message).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-11-26 22:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 21:55 [PATCH v4 0/4] Add support for ADAQ776x-1 ADC Family Jonathan Santos
2025-11-26 21:56 ` [PATCH v4 1/4] dt-bindings: iio: adc: ad7768-1: add new supported parts Jonathan Santos
2025-12-04 8:14 ` Krzysztof Kozlowski
2025-11-26 21:56 ` [PATCH v4 2/4] iio: adc: ad7768-1: introduce chip info for future multidevice support Jonathan Santos
2025-11-26 21:56 ` [PATCH v4 3/4] units: add BASIS_POINTS macro Jonathan Santos
2025-11-26 22:01 ` Andy Shevchenko [this message]
2025-11-26 21:56 ` [PATCH v4 4/4] iio: adc: ad7768-1: add support for ADAQ776x-1 ADC Family Jonathan Santos
2025-12-07 18:24 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSd4t0kln98ptofg@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Jonathan.Santos@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=jonath4nns@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.