Re: [PATCH v2] migration: fix parsing snapshots with x-ignore-shared flag

[Peter Xu <peterx@redhat.com>]

On Wed, Nov 26, 2025 at 09:57:02AM -0300, Fabiano Rosas wrote:
> Pawel Zmarzly <pzmarzly0@gmail.com> writes:
> 
> > Snapshots made with mapped-ram and x-ignore-shared flags are
> > not parsed properly.
> >
> 
> I'd suggest some extra words to help people in the future (no need to
> resend, we can add it while merging):
> 
> "The ignore-shared feature adds and extra field in the stream, which
> needs to be consumed on the destination side. Even though mapped-ram has
> a fixed header format, the ignore-shared is part of the "generic" stream
> infomation so the mapped-ram code is currently skipping that be64 read
> which incorrectly offsets every subsequent read from the stream.
> 
> The current ignore-shared handling can simply be moved earlier in the
> code to encompass mapped-ram as well since the ignore-shared doubleword
> is the first one read when parsing the ramblock section of the stream."
> 
> > Co-authored-by: Peter Xu <peterx@redhat.com>
> > Signed-off-by: Pawel Zmarzly <pzmarzly0@gmail.com>
> 
> taking or leaving my additions:
> Reviewed-by: Fabiano Rosas <farosas@suse.de>
> 
> @Peter, we can probably merge this and deal with the rest of the
> ignore-shared situation later, right?

Yes agreed.

I queued this patch for -rc3 with Fabiano's update on the commit log,
thanks!

-- 
Peter Xu