All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Chuck Lever <cel@kernel.org>
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev, Chuck Lever <chuck.lever@oracle.com>,
	Jeff Layton <jlayton@kernel.org>, NeilBrown <neil@brown.name>,
	Olga Kornievskaia <okorniev@redhat.com>,
	Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>
Subject: Re: [PATCH v1 1/1] nfsd: Mark variable __maybe_unused to avoid W=1 build break
Date: Thu, 27 Nov 2025 08:50:34 +0100	[thread overview]
Message-ID: <aSgCyqR72Zu6TSSI@black.igk.intel.com> (raw)
In-Reply-To: <176338731878.4204.10224670039692915729.b4-ty@oracle.com>

On Mon, Nov 17, 2025 at 08:49:29AM -0500, Chuck Lever wrote:
> On Thu, 13 Nov 2025 09:31:31 +0100, Andy Shevchenko wrote:
> > Clang is not happy about set but (in some cases) unused variable:
> > 
> > fs/nfsd/export.c:1027:17: error: variable 'inode' set but not used [-Werror,-Wunused-but-set-variable]
> > 
> > since it's used as a parameter to dprintk() which might be configured
> > a no-op. To avoid uglifying code with the specific ifdeffery just mark
> > the variable __maybe_unused.

[...]

> Applied to nfsd-testing, thanks!
> 
> [1/1] nfsd: Mark variable __maybe_unused to avoid W=1 build break
>       commit: 56e9f88b25abf08de6f2b1bfbbb2ddc4e6622d1e

Thanks, but still no appearance in Linux Next and problem seems to be present.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2025-11-27  7:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13  8:31 [PATCH v1 1/1] nfsd: Mark variable __maybe_unused to avoid W=1 build break Andy Shevchenko
2025-11-13 13:55 ` Chuck Lever
2025-11-17 13:49 ` Chuck Lever
2025-11-27  7:50   ` Andy Shevchenko [this message]
2025-11-27 16:20     ` Chuck Lever
2025-11-27 16:55       ` Andy Shevchenko
2025-11-27 17:08         ` Chuck Lever
2025-11-27 18:03           ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aSgCyqR72Zu6TSSI@black.igk.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=Dai.Ngo@oracle.com \
    --cc=cel@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=jlayton@kernel.org \
    --cc=justinstitt@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=neil@brown.name \
    --cc=nick.desaulniers+lkml@gmail.com \
    --cc=okorniev@redhat.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.