From: Mike Rapoport <rppt@kernel.org>
To: Nikita Kalyazin <kalyazin@amazon.com>
Cc: linux-mm@kvack.org, Andrea Arcangeli <aarcange@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Axel Rasmussen <axelrasmussen@google.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
David Hildenbrand <david@redhat.com>,
Hugh Dickins <hughd@google.com>,
James Houghton <jthoughton@google.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Michal Hocko <mhocko@suse.com>,
Paolo Bonzini <pbonzini@redhat.com>, Peter Xu <peterx@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Shuah Khan <shuah@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2 5/5] KVM: selftests: test userfaultfd minor for guest_memfd
Date: Thu, 27 Nov 2025 12:39:00 +0200 [thread overview]
Message-ID: <aSgqRAF6Ih8u6fdP@kernel.org> (raw)
In-Reply-To: <18b4cddb-3e04-4272-9f04-6857cea70ff5@amazon.com>
On Wed, Nov 26, 2025 at 04:49:46PM +0000, Nikita Kalyazin wrote:
> On 25/11/2025 18:38, Mike Rapoport wrote:
> > From: Nikita Kalyazin <kalyazin@amazon.com>
> >
> > +static void test_uffd_minor(int fd, size_t total_size)
> > +{
> > + struct uffdio_api uffdio_api = {
> > + .api = UFFD_API,
> > + .features = UFFD_FEATURE_MINOR_GENERIC,
>
> Should it be UFFD_FEATURE_MINOR_SHMEM instead? UFFD_FEATURE_MINOR_GENERIC
> was removed in the v1.
I'll drop .features completely, the checks in UFFDIO_REGISTER are
sufficient.
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2025-11-27 10:39 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 18:38 [PATCH v2 0/5] mm, kvm: add guest_memfd support for uffd minor faults Mike Rapoport
2025-11-25 18:38 ` [PATCH v2 1/5] userfaultfd: move vma_can_userfault out of line Mike Rapoport
2025-11-26 15:05 ` Liam R. Howlett
2025-11-25 18:38 ` [PATCH v2 2/5] userfaultfd, shmem: use a VMA callback to handle UFFDIO_CONTINUE Mike Rapoport
2025-11-26 10:21 ` David Hildenbrand (Red Hat)
2025-11-26 15:11 ` Liam R. Howlett
2025-11-25 18:38 ` [PATCH v2 3/5] mm: introduce VM_FAULT_UFFD_MINOR fault reason Mike Rapoport
2025-11-25 19:21 ` Peter Xu
2025-11-27 11:18 ` Mike Rapoport
2025-11-27 14:10 ` Peter Xu
2025-11-30 11:05 ` Mike Rapoport
2025-11-26 10:19 ` David Hildenbrand (Red Hat)
2025-11-26 12:47 ` kernel test robot
2025-11-26 15:19 ` Liam R. Howlett
2025-11-26 16:49 ` Nikita Kalyazin
2025-11-28 1:48 ` kernel test robot
2025-11-28 3:07 ` kernel test robot
2025-11-25 18:38 ` [PATCH v2 4/5] guest_memfd: add support for userfaultfd minor mode Mike Rapoport
2025-11-26 10:25 ` David Hildenbrand (Red Hat)
2025-11-26 15:22 ` Liam R. Howlett
2025-11-26 16:21 ` kernel test robot
2025-11-26 16:49 ` Nikita Kalyazin
2025-11-27 10:36 ` Mike Rapoport
2025-11-27 11:19 ` Nikita Kalyazin
2025-11-27 19:04 ` Mike Rapoport
2025-11-28 12:15 ` Nikita Kalyazin
2025-11-27 11:27 ` David Hildenbrand (Red Hat)
2025-11-28 3:27 ` kernel test robot
2025-11-25 18:38 ` [PATCH v2 5/5] KVM: selftests: test userfaultfd minor for guest_memfd Mike Rapoport
2025-11-26 15:23 ` Liam R. Howlett
2025-11-26 16:49 ` Nikita Kalyazin
2025-11-27 10:39 ` Mike Rapoport [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-04-02 16:07 [PATCH v2 0/5] KVM: guest_memfd: support for uffd minor Nikita Kalyazin
2025-04-02 16:07 ` [PATCH v2 5/5] KVM: selftests: test userfaultfd minor for guest_memfd Nikita Kalyazin
2025-04-02 21:10 ` James Houghton
2025-04-03 17:02 ` Nikita Kalyazin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSgqRAF6Ih8u6fdP@kernel.org \
--to=rppt@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jthoughton@google.com \
--cc=kalyazin@amazon.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.