Re: [PATCH v2 2/2] mm/swapfile: use plist_for_each_entry in __folio_throttle_swaprate

[Baoquan He <bhe@redhat.com>]

On 11/27/25 at 07:03pm, Youngjun Park wrote:
> The loop breaks immediately after finding the first swap device and
> never modifies the list. Replace plist_for_each_entry_safe() with
> plist_for_each_entry() and remove the unused next variable.

Yeah, and the lock is always held. So this looks good to me.

Reviewed-by: Baoquan He <bhe@redhat.com>

> 
> Signed-off-by: Youngjun Park <youngjun.park@lge.com>
> ---
>  mm/swapfile.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index 8116f36e440b..46d2008e4b99 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -4023,7 +4023,7 @@ static bool __has_usable_swap(void)
>  
>  void __folio_throttle_swaprate(struct folio *folio, gfp_t gfp)
>  {
> -	struct swap_info_struct *si, *next;
> +	struct swap_info_struct *si;
>  
>  	if (!(gfp & __GFP_IO))
>  		return;
> @@ -4042,8 +4042,7 @@ void __folio_throttle_swaprate(struct folio *folio, gfp_t gfp)
>  		return;
>  
>  	spin_lock(&swap_avail_lock);
> -	plist_for_each_entry_safe(si, next, &swap_avail_head,
> -				  avail_list) {
> +	plist_for_each_entry(si, &swap_avail_head, avail_list) {
>  		if (si->bdev) {
>  			blkcg_schedule_throttle(si->bdev->bd_disk, true);
>  			break;
> -- 
> 2.34.1
>