From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 609BC239E6C for ; Thu, 27 Nov 2025 16:56:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764262562; cv=fail; b=m1ZKe+VOpbKNP4ozlJdYssbGmob8omFrw2MqlqxX1O7C4ew8gC1y+naHiI/YfeT/9QzwdMQ/9b/WAOrI3uODw/Ywa21MBlCYTU3uT6DzygpSk2E1qqvaSIHn3giSXmdM61Sl29MWLdGrASCoqQsur9XENLVTLW0M47HMdD56QXA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764262562; c=relaxed/simple; bh=FZyeTFWObIPdg5R5YkxyALUIsZO1sf7VOoAQ8bDhOC8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GojC5GRRq71PHtQSywG6dnpXYm8FDvszaGaYUN4nUP/r37M+x/FvBkapUlWrHBjHl8JZl6K9JcRT/UpyCdG3gqCXC9IE5H5/T+9MMslahz2pIItEtSboOS/xzzEP+tFBNpxtSfyPcXDG7CZBeTNGgfIq1uMCMSNsKsdmj1mqWBY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=f0lWLMYz; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=iAiZxE+9; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="f0lWLMYz"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="iAiZxE+9" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AR61Il0687202; Thu, 27 Nov 2025 10:55:57 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=PODMain02222019; bh=HQqEBzY5M7c96lAeKH HabNHBeO62TfpgStqWWlSoVxc=; b=f0lWLMYzxE5BYbUfuccllqBtL6LKprrsfD mjd7TeRdelxOpivsbvurWjbkyqUKV6EopkOq/8qtc3eDeCGGlFTb+APOcUy3MzWX 86UY3c5NqdHtmRNBMNpdmqb9rp8GX+cegYrnqr0dhXKoy9r3IUt4dHHgpkcHqhLN rsMJlO+8x7gmooeHa6rxL8U7bWYbAoUwm00x1HTp3qMCV/Q7o0u7J6egmdVFUyJc ExbK7LkzFWp9LYvwOTe2LC78TIYqVgT1BEWqyR92MAIn/ZXY93ftP5hjRVr2YvjR 8Ik30jvgLrjlnnLyHVMQN1FyUtYzJ8UejlmUzc5E4Pl4sTE41tmg== Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazon11022100.outbound.protection.outlook.com [40.107.200.100]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 4anjvwtfcq-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 27 Nov 2025 10:55:56 -0600 (CST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=siHRmxb648u508T7uKWINVzsqbRnLmn2UkwTkwM5lyZSjfurv76wUWRkov+Ff4nZHnuU2HigiDWS0fewJWnf+eEbKGeDvIMv0F8OW3G7YjRlq5ZqBLWSq1Y+g2kmt8MRWo5iSIU87hW7/3ig9hJPoH5Y9VVVraP6sArUDq72QRfldPdORY8llIMMWE62mx9Ru2dDx2NPylTaF4h8UWWzxifi76d3xQ4JwdW7uv/KxK7WNc3cDpSlBq0glrGniJYxP31twtal2OqQaqSZJ22CRWnPrIeDtEqEs5rvAm4i6esU7EzRwhgzsFEP6j0vyVG+a96HB8bSzp7U0u5D/58eRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HQqEBzY5M7c96lAeKHHabNHBeO62TfpgStqWWlSoVxc=; b=FYADqObvJsDNUxa9U03QtxzDOZWc/Dr8woisNUUJfclgr0LT2Fzekai2/IaLfr2KJ4D2qu/kVmrP9yyj+M1yV6VPOz2qitnN/KOZnhgZrpyEnsT3gntIaKoMltKG0Zu0wd0zgezaw2YCEhOf/wpB2gF1T64/qp66H1UtPeRC69ca1aP7mrqW3B5TbM7MpppKvfqSpBp1OTb7QhEt30KoZ/Mgk6voZ1+oNSuPS0//15lPJUgG4h7Qks1wLUF2SrnORTfeoeu/6BxD99U/6c0foIAshG1PXl22HWlieEVJ6c5nIw4xyrMVMIH0/H3VUPmbNIYrLSBi/gIPBs+AO+juRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=gmail.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HQqEBzY5M7c96lAeKHHabNHBeO62TfpgStqWWlSoVxc=; b=iAiZxE+90JmwmNlSs3zb3TbhaTqJaceBPOgZwQTSCWrdOG9VTQW09H4j9mIO3ElKmh0XRXVUOGLIahiJJtqlvq7yovTj+Wp8u5pEBKcZpjinPH4ki2J+ev4qjTRhELZv+1ZsG5ph8IT63ueGuDxxTH+LSSmniARJlIcJFoyjOLQ= Received: from CH0PR04CA0074.namprd04.prod.outlook.com (2603:10b6:610:74::19) by CY8PR19MB7667.namprd19.prod.outlook.com (2603:10b6:930:77::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.14; Thu, 27 Nov 2025 16:55:53 +0000 Received: from CH2PEPF0000013B.namprd02.prod.outlook.com (2603:10b6:610:74:cafe::ad) by CH0PR04CA0074.outlook.office365.com (2603:10b6:610:74::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9366.14 via Frontend Transport; Thu, 27 Nov 2025 16:55:35 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by CH2PEPF0000013B.mail.protection.outlook.com (10.167.244.68) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9366.7 via Frontend Transport; Thu, 27 Nov 2025 16:55:52 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 81E45406543; Thu, 27 Nov 2025 16:55:51 +0000 (UTC) Received: from opensource.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 6E3E282024D; Thu, 27 Nov 2025 16:55:51 +0000 (UTC) Date: Thu, 27 Nov 2025 16:55:50 +0000 From: Charles Keepax To: sparkhuang Cc: Liam Girdwood , Mark Brown , Charles Keepax , linux-kernel@vger.kernel.org, weipengliang@xiaomi.com, wengjinfei@xiaomi.com, caodan1@xiaomi.com Subject: Re: [PATCH v2] regulator: core: Protect regulator_supply_alias_list with regulator_list_mutex Message-ID: References: <877bdd6a-0ab1-4d54-96ba-ca7073f882e7@sirena.org.uk> <20251127025716.5440-1-huangshaobo3@xiaomi.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251127025716.5440-1-huangshaobo3@xiaomi.com> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF0000013B:EE_|CY8PR19MB7667:EE_ X-MS-Office365-Filtering-Correlation-Id: ee1ab800-06ef-41a9-3aee-08de2dd5d368 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|36860700013|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?uAhST3KopWVKOFbfUbpcI7ceTzJVOw8H4vjD3HZlMIg5PhQu+Y0HjQOCrqtm?= =?us-ascii?Q?JAY9iVIgb9QQ+Nz7tnHsqgTHv4r9e0fmLJOWFZVCq3jpCoa37l+fp0FyqTAq?= =?us-ascii?Q?tSq8Z6RZ3wK0jGObPpLb28yVA2x9YtfHDHed+JxOW9lNXHQWE7FU9zERxXCM?= =?us-ascii?Q?2z4WZ6ij6zs8Zpf4obK0Q3PioSapoaN+S6a3UTGE7J+V9Al0WIM/F4Ab7H/L?= =?us-ascii?Q?heT2V4/AdVKSQ0Q9D3KE8dgNhutMPlHie8qJXLQo+YnX7mtQtfg9+jUdrPxg?= =?us-ascii?Q?p7fl/FGDf6Wzg1iLFwjjR/8QL81UL93Q35tVJL5aFJp70B5IgWGV3cykDZsd?= =?us-ascii?Q?vbNURvBqS3mOQuW9rb6zGt7K7sRUzmAyp83unLRKmhMv1TlMSUNmr6AIVV0b?= =?us-ascii?Q?KBK677mUPWeiktg1xbKG7sMmCIzDivzLT8oboIsMt+kOO1Hj0EOVDzRgeOJC?= =?us-ascii?Q?4Zj5MQGzE3bVpOpXpNUDHkwhiBuVMr2jPQWjvHVuE5ncRIfYNnExbMJcadbt?= =?us-ascii?Q?Pjb9VxcFqKuC47hlhpVYZ7LAPA88wZp1z2T/Au+ObMS5KQWX3jtQu7fvryNM?= =?us-ascii?Q?lPcYyf4tEqQOfPE+CaRSTeQ/3k9jrO0oOUQkC7ZZwHAv+MFzf617qi2b//3G?= =?us-ascii?Q?MWdSOy5K/LV09bMNTcdcy1EjO+S81oA7HWyygHKiYSzVCIJxbsz0BKKxMKjw?= =?us-ascii?Q?pwNuNMNXCSyUDwEewxM8V0B70eQdQJaWjz0vtbCrSYaqAz8Zr7sILzmsU+0J?= =?us-ascii?Q?9JVP29dYX4Cmga7nmyMhRbLr1U+ZnoXcy/vfM+sWUVcbaUwqnAmQ9Un7EqVQ?= =?us-ascii?Q?AdnYs18US0sRGsqbRnM9867Nr3qT8Y8xA01+A5T54+kedQj/24QhbdPBtd6F?= =?us-ascii?Q?ytYNipORSID1oHpj5Bz8eYCclOHoUxITO6Bc42iw4VTNo/6Gh49nArsztFmk?= =?us-ascii?Q?md+3Y0jPjSE2jmJ/YsE5+XkmN15++4jEU2xqADIAmb2XfxQjlam0bGCeBiRO?= =?us-ascii?Q?YIQj0lJS00OV/Tw77Vw6c6PsAzqrBlI2TdbXA5I52PwKHtYKfAvL+PgqB5BT?= =?us-ascii?Q?5qp60wWO83KzY6ORhsE95p02Ct63dfMFZhKkPYHp5pd5S7oIL6+WGZ75PRu5?= =?us-ascii?Q?yY5LmlqJu0yAuYXnGUFHXNNsHubQqkE7DVENNW1ylvi2a72mOpNDPy9NUXy7?= =?us-ascii?Q?Nz+jwfP6DXdcwYLMxbUVSIJyBmGdcBzHOv7EJuIdFMRBjmanHEjfFQDY3Sz3?= =?us-ascii?Q?aW/nLsBpJ5ulO3Se97OG6Ae6991YSi6sclfParepejZRCYufiWWZuDAcTCoF?= =?us-ascii?Q?d4UQO8Ws+TFyLOKnnrJqthdpCCuYQxewF7171m0oOdQvgbV/YC4ZM/IlaWdy?= =?us-ascii?Q?vqcpPhAuT7rGVrByuk4bFuQg8ZNcFR9AGKnCVVWmVv5NW5uoT5YTXNjQkLXS?= =?us-ascii?Q?gF40D/POquoEro7Hfh2SSD3ClWk5GXgSJi/NMSLPocMdt/h1D3MNIDkzGzCW?= =?us-ascii?Q?dDdv3oNdcYFxi+F/Rpp23DF0CwnvoOxc15OyuqIL3vFundVdvi1vIg8Ew0s6?= =?us-ascii?Q?PxuauB+Z3Y4ffIakX6o=3D?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(61400799027)(36860700013)(376014)(82310400026);DIR:OUT;SFP:1102; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2025 16:55:52.8763 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ee1ab800-06ef-41a9-3aee-08de2dd5d368 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-CH2PEPF0000013B.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR19MB7667 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-ORIG-GUID: kVFd-OngZlAefb2gPQzTwk68a7iHYVuN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI3MDEyNiBTYWx0ZWRfX0H6yZ3MvV5Mh J2J5EwP01kjsMDXVm2GflVneCQH5yQqevVVTLuPx6t9aeH53NGeqFaA5n5Rw1q+JQQI1FNf8et5 Rw4fwaqZH6Z4IVa8G3ehfUNNP8LNksD6XYvF65MxbhXfkEzFzWTkwIQoUDudBffAEnnFU63gaLD YYtmlOhUl8nwDju+FhZ690jPsE6hYCUTpduQrh//KSV3EDWlp+0Ncp7wiFSk4ZLwZ/4WNuVNpMg jrdtFA7crPufqI16QGTfekib0VYX2Npl8z/I4pugN/M5OEoICqZWz9ce5XSXzjYJh4zJ+iSIvRc LZtQJ+dmaOxS4TzmVevi2V5sdnsxxgBGD70QFt45JVhVLcppgFR3d//C+cfWAn467rYq4zn6l8g o2GDetTKQLVMRQdoqFMwxo+wPmBXZA== X-Authority-Analysis: v=2.4 cv=Vvouwu2n c=1 sm=1 tr=0 ts=6928829c cx=c_pps a=eFEjX9j3IP+CJDDqlGDD1w==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=kj9zAlcOel0A:10 a=6UeiqGixMTsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=IeNN-m2dAAAA:8 a=w1d2syhTAAAA:8 a=BKVDKHSaAaxIuPEsQkYA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-GUID: 3eg3HboBAgnRMfgNnnr4LghLuwcO7_Z1 X-Proofpoint-Spam-Reason: safe On Thu, Nov 27, 2025 at 10:57:16AM +0800, sparkhuang wrote: > regulator_supply_alias_list was accessed without any locking in > regulator_supply_alias(), regulator_register_supply_alias(), and > regulator_unregister_supply_alias(). Concurrent registration, > unregistration and lookups can race, leading to: > > 1 use-after-free if an alias entry is removed while being read, > 2 duplicate entries when two threads register the same alias, > 3 inconsistent alias mappings observed by consumers. > > Protect all traversals, insertions and deletions on > regulator_supply_alias_list with the existing regulator_list_mutex. > > Fixes: a06ccd9c3785f ("regulator: core: Add ability to create a lookup alias for supply") > Signed-off-by: sparkhuang > --- Reviewed-by: Charles Keepax Thanks, Charles