Re: [nft PATCH RFC 1/6] parser_bison: Introduce tokens for monitor events

[Florian Westphal <fw@strlen.de>]

Phil Sutter <phil@nwl.cc> wrote:
> There already is a start condition for "monitor" keyword and also a
> DESTROY token. So just add the missing one and get rid of the
> intermediate string buffer.
> 
> Keep checking the struct monitor::event value in eval phase just to be
> on the safe side.

Looks good, just minor nits below:

> diff --git a/include/rule.h b/include/rule.h
> index e8b3c0376e367..4c647f732caf2 100644
> --- a/include/rule.h
> +++ b/include/rule.h
> @@ -739,15 +739,22 @@ enum {
>  	CMD_MONITOR_OBJ_MAX
>  };
>  
> +enum {
> +	CMD_MONITOR_EVENT_ANY,
> +	CMD_MONITOR_EVENT_NEW,
> +	CMD_MONITOR_EVENT_DEL,
> +	CMD_MONITOR_EVENT_MAX
> +};
> +
>  struct monitor {
>  	struct location	location;
>  	uint32_t	format;
>  	uint32_t	flags;
>  	uint32_t	type;
> -	const char	*event;
> +	uint32_t	event;

any reason for using u32_t rather than an enum?

> -struct monitor *monitor_alloc(uint32_t format, uint32_t type, const char *event);
> +struct monitor *monitor_alloc(uint32_t format, uint32_t type, uint32_t event);

If we can get rid of internal parsing I would prefer
	... , enum monitor_event_type event); or similar.