From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH RFC 2/6] parser_bison: Introduce tokens for chain types
Date: Fri, 28 Nov 2025 16:07:29 +0100 [thread overview]
Message-ID: <aSm6sRVaq8ciWL-2@strlen.de> (raw)
In-Reply-To: <20251126151346.1132-3-phil@nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> Use the already existing SCANSTATE_TYPE for keyword scoping.
> This is a bit of back-n-forth from string to token and back to string
> but it eliminates the helper function and also takes care of error
> handling.
Did you run this with valgrind or CFLAGS+=-fsanitize=address ?
> + $<chain>0->type.str = xstrdup($2);
This should probably be $<chain>0->type.str = $2;
No?
next prev parent reply other threads:[~2025-11-28 15:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 15:13 [nft PATCH RFC 0/6] parser_bison: Less STRING more tokens Phil Sutter
2025-11-26 15:13 ` [nft PATCH RFC 1/6] parser_bison: Introduce tokens for monitor events Phil Sutter
2025-11-28 14:51 ` Florian Westphal
2025-11-28 15:13 ` Phil Sutter
2025-11-26 15:13 ` [nft PATCH RFC 2/6] parser_bison: Introduce tokens for chain types Phil Sutter
2025-11-28 15:07 ` Florian Westphal [this message]
2025-11-28 15:38 ` Phil Sutter
2025-11-26 15:13 ` [nft PATCH RFC 3/6] parser_bison: Introduce tokens for osf ttl values Phil Sutter
2025-11-28 15:14 ` Florian Westphal
2025-11-26 15:13 ` [nft PATCH RFC 4/6] parser_bison: Introduce tokens for log levels Phil Sutter
2025-11-28 15:15 ` Florian Westphal
2025-11-26 15:13 ` [nft PATCH RFC 5/6] parser_bison: Introduce bytes_unit Phil Sutter
2025-11-28 15:50 ` Florian Westphal
2025-11-26 15:13 ` [nft PATCH RFC 6/6] scanner: Introduce SCANSTATE_RATE Phil Sutter
2025-11-28 17:40 ` Florian Westphal
2025-11-28 18:07 ` Phil Sutter
2025-11-28 18:11 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSm6sRVaq8ciWL-2@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.