Re: [nft PATCH RFC 6/6] scanner: Introduce SCANSTATE_RATE

[Phil Sutter <phil@nwl.cc>]

On Fri, Nov 28, 2025 at 06:40:00PM +0100, Florian Westphal wrote:
> Phil Sutter <phil@nwl.cc> wrote:
> >  struct limit_rate {
> >  	uint64_t rate, unit;
> >  };
> > diff --git a/include/parser.h b/include/parser.h
> > index 8cfd22e9e6c42..889302baf5950 100644
> > --- a/include/parser.h
> > +++ b/include/parser.h
> > @@ -47,6 +47,7 @@ enum startcond_type {
> >  	PARSER_SC_META,
> >  	PARSER_SC_POLICY,
> >  	PARSER_SC_QUOTA,
> > +	PARSER_SC_RATE,
> 
> Could this new scanstate get added in a different patch?
> 
> > -"hour"			{ return HOUR; }
> > -"day"			{ return DAY; }
> > +<*>"hour"		{ return HOUR; }
> > +<*>"day"		{ return DAY; }
> 
> this might allow to scope this to meta+rate first before adding
> the exclusive start condition change.

Sadly, not. Unless you want to get rid of meta_key_unqualified as well:
Since nft accepts rules like "hour 10 accept", we have to keep "hour"
and "day" in global scope.

Cheers, Phil