From: Simon Horman <horms@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org,
gustavold@gmail.com, asantostc@gmail.com, calvin@wbinvd.org,
kernel-team@meta.com
Subject: Re: [PATCH net-next 2/4] netconsole: Add configfs attribute for direct message sending
Date: Sun, 30 Nov 2025 15:32:14 +0000 [thread overview]
Message-ID: <aSxjfmcOPjHn1qWG@horms.kernel.org> (raw)
In-Reply-To: <20251128-netconsole_send_msg-v1-2-8cca4bbce9bc@debian.org>
On Fri, Nov 28, 2025 at 06:20:47AM -0800, Breno Leitao wrote:
> Add a new write-only configfs attribute "send_msg" to netconsole targets
> that allows sending arbitrary messages directly through netconsole.
>
> This feature enables users to send custom messages through netconsole
> without having to go through the kernel logging infrastructure. Messages
> can be sent by simply writing to:
> /sys/kernel/config/netconsole/<target>/send_msg
>
> The implementation:
> - Checks if the target is enabled before sending
> - Verifies the network interface is running
> - Handles both basic and extended message formats
> - Fragments large messages when needed for basic targets
> - Reuses existing send_msg_udp() and send_ext_msg_udp() functions
>
> Unfortunately this patch has two forward declaration, which is not
> ideal, but, moving send_msg_udp() functions earlier would cause too many
> changes, and this could be done in an idependent patch.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-11-30 15:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 14:20 [PATCH net-next 0/4] (no cover subject) Breno Leitao
2025-11-28 14:20 ` [PATCH net-next 1/4] netconsole: extract message fragmentation into send_msg_udp() Breno Leitao
2025-11-30 15:32 ` Simon Horman
2025-11-28 14:20 ` [PATCH net-next 2/4] netconsole: Add configfs attribute for direct message sending Breno Leitao
2025-11-30 15:32 ` Simon Horman [this message]
2025-11-28 14:20 ` [PATCH net-next 3/4] selftests/netconsole: Switch to configfs send_msg interface Breno Leitao
2025-11-30 15:32 ` Simon Horman
2025-11-28 14:20 ` [PATCH net-next 4/4] Documentation: netconsole: Document send_msg configfs attribute Breno Leitao
2025-11-30 15:32 ` Simon Horman
2025-11-30 15:34 ` [PATCH net-next 0/4] (no cover subject) Simon Horman
2025-12-02 0:36 ` Jakub Kicinski
2025-12-02 10:18 ` Breno Leitao
2025-12-02 18:24 ` Jakub Kicinski
2025-12-04 10:46 ` Petr Mladek
2025-12-04 10:51 ` Petr Mladek
2025-12-05 10:21 ` Breno Leitao
2025-12-08 14:52 ` Petr Mladek
2025-12-09 17:36 ` Breno Leitao
2025-12-09 7:37 ` Jakub Kicinski
2025-12-09 17:46 ` Breno Leitao
2025-12-10 4:05 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSxjfmcOPjHn1qWG@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=asantostc@gmail.com \
--cc=calvin@wbinvd.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavold@gmail.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.