Re: [PATCH net-next 01/15] net: dsa: mt7530: unexport mt7530_switch_ops

[Daniel Golle <daniel@makrotopia.org>]

On Sun, Nov 30, 2025 at 03:16:43PM +0200, Vladimir Oltean wrote:
> Commit cb675afcddbb ("net: dsa: mt7530: introduce separate MDIO driver")
> exported mt7530_switch_ops for use from mt7530-mmio.c. Later in the
> patch set, mt7530-mmio.c used mt7530_probe_common() to access the
> mt7530_switch_ops still from mt7530.c - see commit 110c18bfed41 ("net:
> dsa: mt7530: introduce driver for MT7988 built-in switch").
> 
> This proves that exporting mt7530_switch_ops was unnecessary, so
> unexport it back.
> 
> Cc: "Chester A. Unal" <chester.a.unal@arinc9.com>
> Cc: Daniel Golle <daniel@makrotopia.org>
> Cc: DENG Qingfang <dqfext@gmail.com>
> Cc: Sean Wang <sean.wang@mediatek.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Daniel Golle <daniel@makrotopia.org>
Acked-by: Daniel Golle <daniel@makrotopia.org>

> ---
>  drivers/net/dsa/mt7530.c | 3 +--
>  drivers/net/dsa/mt7530.h | 1 -
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
> index 548b85befbf4..1acb57002014 100644
> --- a/drivers/net/dsa/mt7530.c
> +++ b/drivers/net/dsa/mt7530.c
> @@ -3254,7 +3254,7 @@ static int mt7988_setup(struct dsa_switch *ds)
>  	return mt7531_setup_common(ds);
>  }
>  
> -const struct dsa_switch_ops mt7530_switch_ops = {
> +static const struct dsa_switch_ops mt7530_switch_ops = {
>  	.get_tag_protocol	= mtk_get_tag_protocol,
>  	.setup			= mt753x_setup,
>  	.preferred_default_local_cpu_port = mt753x_preferred_default_local_cpu_port,
> @@ -3291,7 +3291,6 @@ const struct dsa_switch_ops mt7530_switch_ops = {
>  	.conduit_state_change	= mt753x_conduit_state_change,
>  	.port_setup_tc		= mt753x_setup_tc,
>  };
> -EXPORT_SYMBOL_GPL(mt7530_switch_ops);
>  
>  static const struct phylink_mac_ops mt753x_phylink_mac_ops = {
>  	.mac_select_pcs	= mt753x_phylink_mac_select_pcs,
> diff --git a/drivers/net/dsa/mt7530.h b/drivers/net/dsa/mt7530.h
> index 7e47cd9af256..3e0090bed298 100644
> --- a/drivers/net/dsa/mt7530.h
> +++ b/drivers/net/dsa/mt7530.h
> @@ -939,7 +939,6 @@ static inline void INIT_MT7530_DUMMY_POLL(struct mt7530_dummy_poll *p,
>  int mt7530_probe_common(struct mt7530_priv *priv);
>  void mt7530_remove_common(struct mt7530_priv *priv);
>  
> -extern const struct dsa_switch_ops mt7530_switch_ops;
>  extern const struct mt753x_info mt753x_table[];
>  
>  #endif /* __MT7530_H */
> -- 
> 2.34.1
>