From: Dan Carpenter <dan.carpenter@linaro.org>
To: Zixuan Dong <dbeidachazi@foxmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, straube.linux@gmail.com
Subject: Re: [PATCH] staging: rtl8723bs: Fix block comment coding style
Date: Mon, 15 Dec 2025 09:04:07 +0300 [thread overview]
Message-ID: <aT-k12fYkV_FtoTW@stanley.mountain> (raw)
In-Reply-To: <tencent_9CA8125E2399DA1ADBDBB8FF585FC95A3606@qq.com>
On Mon, Dec 15, 2025 at 12:01:28PM +0800, Zixuan Dong wrote:
> Fix the following checkpatch warnings in os_intfs.c:
>
> WARNING: Block comments use * on subsequent lines
> WARNING: Block comments use a trailing */ on a separate line
>
> Signed-off-by: Zixuan Dong <dbeidachazi@foxmail.com>
> ---
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 18 ++++++++++--------
> 1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index 6ca6dc548805..cd81d9e4a3d2 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -934,14 +934,16 @@ static int netdev_close(struct net_device *pnetdev)
> padapter->net_closed = true;
> padapter->netif_up = false;
>
> -/*if (!padapter->hw_init_completed)
> - {
> -
> - padapter->bDriverStopped = true;
> -
> - rtw_dev_unload(padapter);
> - }
> - else*/
> +/*
> + * if (!padapter->hw_init_completed)
> + * {
> + *
> + * padapter->bDriverStopped = true;
> + *
> + * rtw_dev_unload(padapter);
> + * }
> + * else
> + */
Just delete this dead code.
regards,
dan carpenter
next prev parent reply other threads:[~2025-12-15 6:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 4:01 [PATCH] staging: rtl8723bs: Fix block comment coding style Zixuan Dong
2025-12-15 6:04 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-12-28 19:44 [PATCH] staging: rtl8723bs: fix " Ofir Mirovsky
2025-12-14 14:26 Adrish Bora
2025-12-17 13:06 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aT-k12fYkV_FtoTW@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=dbeidachazi@foxmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.