From: Simon Horman <horms@kernel.org>
To: Harshitha Ramamurthy <hramamurthy@google.com>
Cc: netdev@vger.kernel.org, joshwash@google.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com,
willemb@google.com, pkaligineedi@google.com, thostet@google.com,
linux-kernel@vger.kernel.org, Ankit Garg <nktgrg@google.com>
Subject: Re: [PATCH net-next] gve: Move gve_init_clock to after AQ CONFIGURE_DEVICE_RESOURCES call
Date: Wed, 3 Dec 2025 18:49:15 +0000 [thread overview]
Message-ID: <aTCGK4DtwVkY4FkI@horms.kernel.org> (raw)
In-Reply-To: <20251202200207.1434749-1-hramamurthy@google.com>
On Tue, Dec 02, 2025 at 08:02:07PM +0000, Harshitha Ramamurthy wrote:
> From: Tim Hostetler <thostet@google.com>
>
> commit 46e7860ef941 ("gve: Move ptp_schedule_worker to gve_init_clock")
> moved the first invocation of the AQ command REPORT_NIC_TIMESTAMP to
> gve_probe(). However, gve_init_clock() invoking REPORT_NIC_TIMESTAMP is
> not valid until after gve_probe() invokes the AQ command
> CONFIGURE_DEVICE_RESOURCES.
>
> Failure to do so results in the following error:
>
> gve 0000:00:07.0: failed to read NIC clock -11
>
> This was missed earlier because the driver under test was loaded at
> runtime instead of boot-time. The boot-time driver had already
> initialized the device, causing the runtime driver to successfully call
> gve_init_clock() incorrectly.
>
> Fixes: 46e7860ef941 ("gve: Move ptp_schedule_worker to gve_init_clock")
> Reviewed-by: Ankit Garg <nktgrg@google.com>
> Signed-off-by: Tim Hostetler <thostet@google.com>
> Signed-off-by: Harshitha Ramamurthy <hramamurthy@google.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-12-03 18:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 20:02 [PATCH net-next] gve: Move gve_init_clock to after AQ CONFIGURE_DEVICE_RESOURCES call Harshitha Ramamurthy
2025-12-03 18:49 ` Simon Horman [this message]
2025-12-05 3:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTCGK4DtwVkY4FkI@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hramamurthy@google.com \
--cc=joshwash@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nktgrg@google.com \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=richardcochran@gmail.com \
--cc=thostet@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.