From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18D14D1BDD2 for ; Wed, 3 Dec 2025 19:20:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id D7C4460DA8; Wed, 3 Dec 2025 19:20:57 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id SyFu6iIEVZXd; Wed, 3 Dec 2025 19:20:56 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org A309160D90 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1764789656; bh=cJUC0GB8thKSS8PVWCARmQPfyWr9u+ZQx/kgiCWj15s=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=eyVc9ocWyTpQHSc1RNl9JM7sO0WsVK0Ds5JgZXB+PTDepUkdc9FZCS2iW7F9IK6z6 a/77NCC2muQVA9Pm/w77ylNascoxCN+R3n6lyXZqG7Z08aZfSwu/Y1rs/v1GC4uAu8 bn5gfb03OrJPdIx8X4aZMTHcGY2pki9yyyd8Fc7GkZ0AOrkNtzvnl9WnP5f0+YZrjc izUuQheJOVWna42pH5zpFbRS+ywWNLEUmUVKVvv7d2Q7fxOlHTzCPkiy4VJHqKraj8 LI3DujBQKVY5hmoW7Ja019qLFv0jMWYuNt5HZsK0JwD7of74d6wJhDMjVe4JWolKuK lgwS8O0TwTggg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id A309160D90; Wed, 3 Dec 2025 19:20:56 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists1.osuosl.org (Postfix) with ESMTP id 2FB0AE7 for ; Wed, 3 Dec 2025 19:20:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 16663404F1 for ; Wed, 3 Dec 2025 19:20:56 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id tkgVzm0Tg5et for ; Wed, 3 Dec 2025 19:20:55 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 73754402B0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 73754402B0 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by smtp2.osuosl.org (Postfix) with ESMTPS id 73754402B0 for ; Wed, 3 Dec 2025 19:20:55 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id E2C8B436F3; Wed, 3 Dec 2025 19:20:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6C62C4CEF5; Wed, 3 Dec 2025 19:20:53 +0000 (UTC) Date: Wed, 3 Dec 2025 19:20:51 +0000 From: Simon Horman To: Sreedevi Joshi Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Madhu Chittim , Aleksandr Loktionov Message-ID: References: <20251202231246.63157-1-sreedevi.joshi@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251202231246.63157-1-sreedevi.joshi@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764789654; bh=ZnPbMo3fPG4x1Tmo8aoqCCJpO2A0R+NRhXVuFJuqh4s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HJ6cXCBVqjY2+oXN9hqZg9KWj8ALzbqjVqpEjWKOEPcyvqw7Dgw0EnvuZdHP3veZL 36jIjH0V/3XO1eTtsgbH8qkcTsYW/otZ797EztJb4KQFIZVdOrCkhXIakkCUh9QifM uujEziK1QOYOYExqKgW4+dGe3D9wsViYDPAMtL7INARikfSt8ZNXoERRB0LVRNuiVT 1noSM1f+8sogcU5PVdEoUaOoSoZIeQfSquJ82LVQdblRv6a0eAHt3Zan+BbGAYj7GW 9TKGROkD0itNqh+P9lmJFjwmOlg7V0jTKgF6zpEdxDPPqULNjIasLX9a9rzvm+Ui+7 nbpqs0LcEBeEQ== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=HJ6cXCBV Subject: Re: [Intel-wired-lan] [PATCH iwl-net] idpf: Fix error handling in idpf_vport_open() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Dec 02, 2025 at 05:12:46PM -0600, Sreedevi Joshi wrote: > Fix error handling to properly cleanup interrupts when > idpf_vport_queue_ids_init() or idpf_rx_bufs_init_all() fail. Jump to > 'intr_deinit' instead of 'queues_rel' to ensure interrupts are cleaned up > before releasing other resources. > > Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport") > Signed-off-by: Sreedevi Joshi > Reviewed-by: Madhu Chittim > Reviewed-by: Aleksandr Loktionov Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6258C314D0D for ; Wed, 3 Dec 2025 19:20:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764789655; cv=none; b=JHi+u+gnmuMWQo4heEQi1Wp72z5/skRjQKFoFcGNj0e0KSrr4zgD+tIp2YUxQf0PAntRA41E7V7l5BzaGksizFE/PMsmWuWNKMv5/oxuxj9QcMy30Fo1pJVL5kSYrxpdUjYEiBaeN+9aQQ7vICgi92FjmMp0CfOTjPp715oFjI4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764789655; c=relaxed/simple; bh=ZnPbMo3fPG4x1Tmo8aoqCCJpO2A0R+NRhXVuFJuqh4s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YrupL5xuO9SqZmxGUk2hT5q3XnZ+wd5fraQGY73jPJNjaGGSPW/iHLgPK/8NfENd6g9wW45ev34OwWsuGRAc5prXZAw4K5JwJb6eCegf5DLDbs9HsQ77E0WoGsTjSKdscK9pUQOG7imMPwTDbmVNvlEGQj+cPDSej68AWgWfzT4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HJ6cXCBV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HJ6cXCBV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6C62C4CEF5; Wed, 3 Dec 2025 19:20:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764789654; bh=ZnPbMo3fPG4x1Tmo8aoqCCJpO2A0R+NRhXVuFJuqh4s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HJ6cXCBVqjY2+oXN9hqZg9KWj8ALzbqjVqpEjWKOEPcyvqw7Dgw0EnvuZdHP3veZL 36jIjH0V/3XO1eTtsgbH8qkcTsYW/otZ797EztJb4KQFIZVdOrCkhXIakkCUh9QifM uujEziK1QOYOYExqKgW4+dGe3D9wsViYDPAMtL7INARikfSt8ZNXoERRB0LVRNuiVT 1noSM1f+8sogcU5PVdEoUaOoSoZIeQfSquJ82LVQdblRv6a0eAHt3Zan+BbGAYj7GW 9TKGROkD0itNqh+P9lmJFjwmOlg7V0jTKgF6zpEdxDPPqULNjIasLX9a9rzvm+Ui+7 nbpqs0LcEBeEQ== Date: Wed, 3 Dec 2025 19:20:51 +0000 From: Simon Horman To: Sreedevi Joshi Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Madhu Chittim , Aleksandr Loktionov Subject: Re: [PATCH iwl-net] idpf: Fix error handling in idpf_vport_open() Message-ID: References: <20251202231246.63157-1-sreedevi.joshi@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251202231246.63157-1-sreedevi.joshi@intel.com> On Tue, Dec 02, 2025 at 05:12:46PM -0600, Sreedevi Joshi wrote: > Fix error handling to properly cleanup interrupts when > idpf_vport_queue_ids_init() or idpf_rx_bufs_init_all() fail. Jump to > 'intr_deinit' instead of 'queues_rel' to ensure interrupts are cleaned up > before releasing other resources. > > Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport") > Signed-off-by: Sreedevi Joshi > Reviewed-by: Madhu Chittim > Reviewed-by: Aleksandr Loktionov Reviewed-by: Simon Horman