From: Patrick Steinhardt <ps@pks.im>
To: Toon Claes <toon@iotcl.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/2] meson: use is_cross_build() where possible
Date: Thu, 4 Dec 2025 07:16:00 +0100 [thread overview]
Message-ID: <aTEnIOjhi_XtHdX8@pks.im> (raw)
In-Reply-To: <20251203145331.621529-1-toon@iotcl.com>
On Wed, Dec 03, 2025 at 03:53:31PM +0100, Toon Claes wrote:
> In previous commit the first use of meson.can_run_host_binaries() was
> introduced. This is a guard around compiler.run() to ensure it's
> actually possible to execute the provided.
>
> In other places we've been having the same issue, but here `not
> meson.is_cross_build()` is used as guard. This does the trick, but it
> also prevents the code from running even when an exe_wrapper is
> configured.
>
> Switch to using meson.can_run_host_binaries() here as well.
>
> There is another place left that still uses `not
> meson.is_cross_build()`, but here it's a guard around fs.exists(). That
> function will always run on the build machine, so checking for
> cross-compilation is still in place here.
Thanks! This series looks good to me, including this patch.
Patrick
next prev parent reply other threads:[~2025-12-04 6:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 10:48 [PATCH 0/2] Few fixes for cross-compiling with Meson Toon Claes
2025-12-02 10:48 ` [PATCH 1/2] meson: ignore subprojects/.wraplock Toon Claes
2025-12-02 10:48 ` [PATCH 2/2] meson: only detect ICONV_OMITS_BOM if possible Toon Claes
2025-12-02 20:27 ` Patrick Steinhardt
2025-12-03 14:55 ` Toon Claes
2025-12-03 14:53 ` [PATCH 3/2] meson: use is_cross_build() where possible Toon Claes
2025-12-04 6:16 ` Patrick Steinhardt [this message]
2025-12-07 10:17 ` [PATCH 0/2] Few fixes for cross-compiling with Meson Carlo Marcelo Arenas Belón
2025-12-08 14:41 ` Toon Claes
2025-12-09 0:44 ` Carlo Arenas
2025-12-11 11:10 ` Toon Claes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTEnIOjhi_XtHdX8@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.