From: Oleg Nesterov <oleg@redhat.com>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: brauner@kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, linux-mm@kvack.org,
willy@infradead.org
Subject: Re: [PATCH v2 2/2] pid: only take pidmap_lock once on alloc
Date: Thu, 4 Dec 2025 15:31:24 +0100 [thread overview]
Message-ID: <aTGbPIsEO94cFHZr@redhat.com> (raw)
In-Reply-To: <20251203092851.287617-3-mjguzik@gmail.com>
On 12/03, Mateusz Guzik wrote:
>
> It has an unintentional side effect of no longer issuing spurious
> idr_preload() around idr_replace().
^^^^^^^^^^^
Around pidfs_add_pid(). The extra idr_preload/end was added by commit
9698d5a483654 ("pidfs: rework inode number allocation") because
pidfs_add_pid() used to call idr_alloc_cyclic(GFP_ATOMIC) too.
The patch looks technically correct to me, so FWIW
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
prev parent reply other threads:[~2025-12-04 14:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 9:28 [PATCH v2 0/2] further damage-control lack of clone scalability Mateusz Guzik
2025-12-03 9:28 ` [PATCH v2 1/2] ns: pad refcount Mateusz Guzik
2025-12-03 9:28 ` [PATCH v2 2/2] pid: only take pidmap_lock once on alloc Mateusz Guzik
2025-12-04 14:31 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTGbPIsEO94cFHZr@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mjguzik@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.