All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel@lists.xenproject.org,
	Doug Goldstein <cardoe@cardoe.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v3 3/4] CI: Add configure --enable-systemd for full build
Date: Fri, 5 Dec 2025 00:18:53 +0100	[thread overview]
Message-ID: <aTIW3V5kR_6Llf7w@mail-itl> (raw)
In-Reply-To: <72bab1bc-6549-4f5a-b521-a4b3c66f7030@citrix.com>

[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

On Thu, Dec 04, 2025 at 11:17:03PM +0000, Andrew Cooper wrote:
> On 04/12/2025 11:11 pm, Marek Marczykowski-Górecki wrote:
> > On Thu, Dec 04, 2025 at 09:54:41PM +0000, Andrew Cooper wrote:
> >> On 04/12/2025 4:53 pm, Marek Marczykowski-Górecki wrote:
> >>> @@ -26,6 +26,7 @@ RUN <<EOF
> >>>          cpio
> >>>          git-core
> >>>          pkg-config
> >>> +        systemd-dev
> >> Why is this needed?  Or rather, does this patch predate my breaking of
> >> the dependency on system-dev?
> > It's still needed, without it the build fails:
> > https://gitlab.com/xen-project/people/marmarek/xen/-/jobs/10959608099
> >
> > Likely related to e54a6cd6a1f3802274cd3a58b07df5f012342192
> 
> Urgh.  Yeah, that breaks the build if systemd isn't installed.

Technically, it breaks "just" --enable-systemd build.

> We also need a build container that does not have systemd anywhere in
> it, to block stuff like that getting in in the first place.

That is Alpine container.

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2025-12-04 23:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-04 16:53 [PATCH v3 0/4] Add driver domains test Marek Marczykowski-Górecki
2025-12-04 16:53 ` [PATCH v3 2/4] CI: Add driver domains tests Marek Marczykowski-Górecki
2025-12-04 16:53 ` [PATCH v3 3/4] CI: Add configure --enable-systemd for full build Marek Marczykowski-Górecki
2025-12-04 21:54   ` Andrew Cooper
2025-12-04 23:11     ` Marek Marczykowski-Górecki
2025-12-04 23:17       ` Andrew Cooper
2025-12-04 23:18         ` Marek Marczykowski-Górecki [this message]
2025-12-04 16:53 ` [PATCH v3 4/4] CI: Run driver domains test on Debian too Marek Marczykowski-Górecki
2025-12-04 21:50 ` [PATCH v3 1/4] automation: switch to alpine:3.22 Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aTIW3V5kR_6Llf7w@mail-itl \
    --to=marmarek@invisiblethingslab.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=cardoe@cardoe.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.