From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Carlos Maiolino <cem@kernel.org>, xfs <linux-xfs@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] xfs: fix a UAF problem in xattr repair
Date: Fri, 5 Dec 2025 00:05:45 -0800 [thread overview]
Message-ID: <aTKSWb-wR7pQ43Mk@infradead.org> (raw)
In-Reply-To: <20251204214350.GM89472@frogsfrogsfrogs>
On Thu, Dec 04, 2025 at 01:43:50PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> The xchk_setup_xattr_buf function can allocate a new value buffer, which
> means that any reference to ab->value before the call could become a
> dangling pointer. Fix this by moving an assignment to after the buffer
> setup.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Do you have a test case for this?
next prev parent reply other threads:[~2025-12-05 8:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 21:43 [PATCH] xfs: fix a UAF problem in xattr repair Darrick J. Wong
2025-12-05 8:05 ` Christoph Hellwig [this message]
2025-12-05 17:12 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTKSWb-wR7pQ43Mk@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.