From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDBE5D32D9C for ; Fri, 5 Dec 2025 15:11:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 7E457607E0; Fri, 5 Dec 2025 15:11:28 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id B10OkLHOvgn1; Fri, 5 Dec 2025 15:11:27 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org A8CC260804 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1764947487; bh=rTYz3X8IR6znjVFq2ide3bkVAPpgJHTwjknKT+LXwqI=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=nvopGcI9Mhh6ofadkq+uDD0jApdov8M2Q3oNew5AC0/eKhvVCBRPmhCMnxHGyQtDH 9+nuiFqp5s0M54j/6GYLi1rNeJ2cO1R+jJny+dpOFv0oeBVhF5cA7NR4sYun//DOZF +GfxvRPAz8SixCKDiN4LFUSmnhI88cXeMZkpIPHcci/PAHDaIhwxz00BkNvl69P63L /3z2SsVAmC1FpaMGGYsqRf7aniZwU8e27JkzcPyAL02spZLFNRvWClsxHL4SquoZa4 o3DoY6MyEcQhJfobUeqAwPC0RXOU/Dxy0vSjssw0RdY1hT9X3lK+HlMPpUriTRv1VN jWSVVWiFrAARQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id A8CC260804; Fri, 5 Dec 2025 15:11:27 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists1.osuosl.org (Postfix) with ESMTP id D43231A9 for ; Fri, 5 Dec 2025 15:11:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id C3E5440400 for ; Fri, 5 Dec 2025 15:11:26 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id JLZMvuLWYEMH for ; Fri, 5 Dec 2025 15:11:26 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 05B6C403F4 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 05B6C403F4 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by smtp4.osuosl.org (Postfix) with ESMTPS id 05B6C403F4 for ; Fri, 5 Dec 2025 15:11:25 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 9F7BB43E50; Fri, 5 Dec 2025 15:11:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61291C4CEF1; Fri, 5 Dec 2025 15:11:23 +0000 (UTC) Date: Fri, 5 Dec 2025 15:11:21 +0000 From: Simon Horman To: Aaron Ma Cc: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: References: <20251205082459.1586143-1-aaron.ma@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251205082459.1586143-1-aaron.ma@canonical.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764947485; bh=rTYz3X8IR6znjVFq2ide3bkVAPpgJHTwjknKT+LXwqI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DC/jq4ubJMaW+v+fns6X79hLZyq370HP4m1mPStWc8Yt0epL71c9d1+sdj0L2BMIj zRVIX6tkO9mwcbJjAkL1WgD39SYBuOP4y6eAtOSBCMiGaFAhWkCxmBSbxM3IlEu0+B YCQZ6euQGUSVkooiHbJhMmghqUNNPI5ffa5IgxnyYkffbzz2aYqYlXaMSoOxykqIcG hoEal5Wc3ctm+zCNlCRjx8qH4zv6tO1ciaG4QbBoFS1hhoUuDjxUGENPO7SNmXKdue kJ8EcIVnzi5hzKDZOlMRvAfXUfEQlZLievVCc5Jc+E7CMawqqojh717fnK2fPPLgbA 62Mbic3jG16Tg== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=DC/jq4ub Subject: Re: [Intel-wired-lan] [PATCH v2 1/2] ice: Fix NULL pointer dereference in ice_vsi_set_napi_queues X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, Dec 05, 2025 at 04:24:58PM +0800, Aaron Ma wrote: > Add NULL pointer checks in ice_vsi_set_napi_queues() to prevent crashes > during resume from suspend when rings[q_idx]->q_vector is NULL. Hi Aaron, This is not a review. But a request for the future: please don't post revised patchsets to netdev more than once every 24h. Reasons for this include: allowing allow time for review; and reducing load on shared CI infrastructure. Link: https://docs.kernel.org/process/maintainer-netdev.html Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 483B7347BC6; Fri, 5 Dec 2025 15:11:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764947486; cv=none; b=f9/HKR59O5mhyJAXmYA1tXh8STDPxGidpCGUb/HxvVQ23ANPxDPEjzAj6TgnAQYmsFQj2YlGVIWaPpCEA20uwWtqC0IN52bQXgUQ+w/n+lpAMsuyR3yqXMXLnxZnbsprDEKidBnQUWbufghAPv464icmRExxuSYXKw/lKfejOvs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764947486; c=relaxed/simple; bh=rTYz3X8IR6znjVFq2ide3bkVAPpgJHTwjknKT+LXwqI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EZts/z4760cyQD3nYWC98RUciUH9lpHJ4SDNLpNKRndoyaGMsXDJf4HMOzk8dbwDUnKqA3jrUIiMR0VEHPlFJnt3S8Zui+CfdfRPea9I348/oiANaxm4ZWfxQMKm2qusLAi5dMt6eE+PvlQcwDfjEpK25Gf+qEL5iue1V8iMZsg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DC/jq4ub; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DC/jq4ub" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61291C4CEF1; Fri, 5 Dec 2025 15:11:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764947485; bh=rTYz3X8IR6znjVFq2ide3bkVAPpgJHTwjknKT+LXwqI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DC/jq4ubJMaW+v+fns6X79hLZyq370HP4m1mPStWc8Yt0epL71c9d1+sdj0L2BMIj zRVIX6tkO9mwcbJjAkL1WgD39SYBuOP4y6eAtOSBCMiGaFAhWkCxmBSbxM3IlEu0+B YCQZ6euQGUSVkooiHbJhMmghqUNNPI5ffa5IgxnyYkffbzz2aYqYlXaMSoOxykqIcG hoEal5Wc3ctm+zCNlCRjx8qH4zv6tO1ciaG4QbBoFS1hhoUuDjxUGENPO7SNmXKdue kJ8EcIVnzi5hzKDZOlMRvAfXUfEQlZLievVCc5Jc+E7CMawqqojh717fnK2fPPLgbA 62Mbic3jG16Tg== Date: Fri, 5 Dec 2025 15:11:21 +0000 From: Simon Horman To: Aaron Ma Cc: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] ice: Fix NULL pointer dereference in ice_vsi_set_napi_queues Message-ID: References: <20251205082459.1586143-1-aaron.ma@canonical.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251205082459.1586143-1-aaron.ma@canonical.com> On Fri, Dec 05, 2025 at 04:24:58PM +0800, Aaron Ma wrote: > Add NULL pointer checks in ice_vsi_set_napi_queues() to prevent crashes > during resume from suspend when rings[q_idx]->q_vector is NULL. Hi Aaron, This is not a review. But a request for the future: please don't post revised patchsets to netdev more than once every 24h. Reasons for this include: allowing allow time for review; and reducing load on shared CI infrastructure. Link: https://docs.kernel.org/process/maintainer-netdev.html Thanks!