From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tamir Duberstein <tamird@kernel.org>
Cc: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Kees Cook <kees@kernel.org>,
linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev,
Tamir Duberstein <tamird@gmail.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] printf: add __printf attribute
Date: Sat, 6 Dec 2025 18:11:38 +0200 [thread overview]
Message-ID: <aTRVusbSqh5ZBY-o@smile.fi.intel.com> (raw)
In-Reply-To: <20251206-printf-kunit-printf-attr-v1-1-1682808b51d0@gmail.com>
On Sat, Dec 06, 2025 at 08:19:09AM -0500, Tamir Duberstein wrote:
> This produces better diagnostics when incorrect inputs are passed.
...
> -static void
> +static void __printf(2, 3)
3?!
I think it should be (2, 0). Yes, the both users call it with "%p..." in format
string, but the second parameter tells compiler to check the variadic
arguments, which are absent here. Changing 'const void *p' to '...' will align
it with the given __printf() attribute, but I don't know if this what we want.
> test_hashed(struct kunit *kunittest, const char *fmt, const void *p)
> {
> char buf[PLAIN_BUF_SIZE];
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-12-06 16:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-06 13:19 [PATCH] printf: add __printf attribute Tamir Duberstein
2025-12-06 16:11 ` Andy Shevchenko [this message]
2025-12-06 17:13 ` Tamir Duberstein
2025-12-06 17:49 ` Andy Shevchenko
2025-12-06 17:52 ` Tamir Duberstein
2025-12-06 19:43 ` Andy Shevchenko
2025-12-06 19:57 ` Tamir Duberstein
2025-12-06 21:45 ` Andy Shevchenko
2025-12-08 1:32 ` Tamir Duberstein
2025-12-08 13:30 ` Andy Shevchenko
2025-12-08 14:05 ` Petr Mladek
2025-12-08 21:07 ` Tamir Duberstein
2025-12-16 10:13 ` Petr Mladek
2026-01-15 14:53 ` Tamir Duberstein
2026-01-16 9:31 ` Petr Mladek
2026-01-16 16:26 ` Tamir Duberstein
2025-12-07 1:16 ` kernel test robot
2025-12-07 2:21 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTRVusbSqh5ZBY-o@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tamird@gmail.com \
--cc=tamird@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.