From: Sasha Levin <sashal@kernel.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, netdev@vger.kernel.org,
Ioana Ciornei <ioana.ciornei@nxp.com>
Subject: Re: Please apply 5b1e38c0792cc7a44997328de37d393f81b2501a to 5.15
Date: Sat, 6 Dec 2025 19:38:08 -0500 [thread overview]
Message-ID: <aTTMcMFeq4Bt8wKk@laps> (raw)
In-Reply-To: <20251204002517.GC468348@ax162>
On Wed, Dec 03, 2025 at 05:25:17PM -0700, Nathan Chancellor wrote:
>Hi stable folks,
>
>Please apply commit 5b1e38c0792c ("dpaa2-mac: bail if the dpmacs fwnode
>is not found") to 5.15, where it addresses an instance of
>-Wsometimes-uninitialized with clang-21 and newer, introduced by commit
>3264f599c1a8 ("net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver")
>in 5.14.
>
> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c:54:13: error: variable 'parent' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
> 54 | } else if (is_acpi_node(fwnode)) {
> | ^~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c:58:29: note: uninitialized use occurs here
> 58 | fwnode_for_each_child_node(parent, child) {
> | ^~~~~~
> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c:54:9: note: remove the 'if' if its condition is always true
> 54 | } else if (is_acpi_node(fwnode)) {
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c:43:39: note: initialize the variable 'parent' to silence this warning
> 43 | struct fwnode_handle *fwnode, *parent, *child = NULL;
> | ^
> | = NULL
>
>It applies and builds cleanly for me. If there are any issues, please
>let me know.
Queued up, thanks.
--
Thanks,
Sasha
prev parent reply other threads:[~2025-12-07 0:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 0:25 Please apply 5b1e38c0792cc7a44997328de37d393f81b2501a to 5.15 Nathan Chancellor
2025-12-07 0:38 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTTMcMFeq4Bt8wKk@laps \
--to=sashal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ioana.ciornei@nxp.com \
--cc=nathan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.