Re: [PATCH] arm64: dts: imx95: Use GPU_CGC as core clock for GPU

[Rain Yang <jiyu.yang@oss.nxp.com>]

On Sun, Dec 07, 2025 at 10:01:06AM +0100, Marek Vasut wrote:
>On 12/5/25 9:17 AM, Rain Yang wrote:
>> On Thu, Dec 04, 2025 at 04:25:38AM +0100, Marek Vasut wrote:
>> > On 12/4/25 4:01 AM, Rain Yang wrote:
>> > 
>> > [...]
>> > > > > For the Linux working environment,
>> > > > > CLK_GPU and CLK_GPUAPB are always-on, while CLK_GPU_CGC can be gated off.
>> > > > > 
>> > > > > Regarding the IMX95_CLK_GPUAPB handle, my suggestion was based on the absence
>> > > > > of its frequency in any OPP entry within the frequency table. Removing it
>> > > > > could simplify the OPP handling logic and reduce unnecessary complexity.
>> > > > 
>> > > > If the clock can be disabled by SM, Linux has to make sure they are NOT
>> > > > disabled, so they must be described in DT, right ?
>> > > > 
>> > > > > [1] https://github.com/nxp-imx/linux-imx/commit/695f2bdc57b869ca5189313e4b5fa7eb5a12f622
>> > > Currently, only CLK_GPU_CGC shall be described in the Device Tree[1], as it can be gated.
>> > > The other clocks (CLK_GPU and CLK_GPUAPB) are always-on in the Linux environment,
>> > > so describing any of them in DT is not necessary and would not be proper in this context.
>> > 
>> > Since this discussion is in fact unrelated to this bugfix, I would propose to
>> > fork the discussion into a separate patch. Can you please submit a patch for
>> > the GPUAPB clock ? Note that I believe GPUAPB clock have to be described in
>> > DT, if only because DT is a hardware description, and to make sure the GPUAPB
>> > clock are correctly enabled by the driver.
>> 
>> Okay, I’ll submit a patch later.
>> The commit message should reflect that only CLK_GPU_CGC is enabled.
>
>The commit message , and this change , is unrelated to GPUAPB clock.
The commit message is ambiguous. Could you clarify which parent clock
you are referring to, and whether it can be enabled by CLK_GPU_CGC?
If it was CLK_GPU, CLK_GPU_CGC can't be able to control it.