From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Christian Marangi <ansuelsmth@gmail.com>
Subject: Re: [PATCH 1/1] PCI: Use resource_set_range() that correctly sets ->end
Date: Mon, 8 Dec 2025 16:15:55 +0100 [thread overview]
Message-ID: <aTbrq7QZMYG0M3ka@black.igk.intel.com> (raw)
In-Reply-To: <20251208145654.5294-1-ilpo.jarvinen@linux.intel.com>
On Mon, Dec 08, 2025 at 04:56:54PM +0200, Ilpo Järvinen wrote:
> __pci_read_base() sets resource start and end addresses when resource
> is larger than 4G but pci_bus_addr_t or resource_size_t are not capable
> of representing 64-bit PCI addresses. This creates a problematic
> resource that has non-zero flags but the start and end addresses do not
> yield to resource size of 0 but 1.
>
> Replace custom resource addresses setup with resource_set_range()
> that correctly sets end address as -1 which results in resource_size()
> returning 0.
>
> For consistency, also use resource_set_range() in the other branch that
> does size based resource setup.
Since I have been involved in the related discussion and the patch LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-12-08 15:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-08 14:56 [PATCH 1/1] PCI: Use resource_set_range() that correctly sets ->end Ilpo Järvinen
2025-12-08 15:15 ` Andy Shevchenko [this message]
2025-12-10 17:13 ` Bjorn Helgaas
2025-12-10 17:17 ` Christian Marangi
2025-12-10 21:30 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTbrq7QZMYG0M3ka@black.igk.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=ansuelsmth@gmail.com \
--cc=bhelgaas@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.