From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7CBED3B7E2 for ; Mon, 8 Dec 2025 16:57:28 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1181027.1504112 (Exim 4.92) (envelope-from ) id 1vSeY3-0005WO-7T; Mon, 08 Dec 2025 16:57:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1181027.1504112; Mon, 08 Dec 2025 16:57:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vSeY3-0005WH-4V; Mon, 08 Dec 2025 16:57:19 +0000 Received: by outflank-mailman (input) for mailman id 1181027; Mon, 08 Dec 2025 16:57:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vSeY1-0005Vi-Cs for xen-devel@lists.xenproject.org; Mon, 08 Dec 2025 16:57:17 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1vSeXy-0009hj-2a; Mon, 08 Dec 2025 16:57:15 +0000 Received: from [2a01:cb15:80df:da00:7079:39df:8b4d:ea79] (helo=l14) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vSeXy-007eR4-2H; Mon, 08 Dec 2025 16:57:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date; bh=tyh7rUR1TZifH49DZZ/IvKJaatZDA4M+FIa7Um3V2aE=; b=FU8PtWB80aQttr45UUl69Nve4P hOBH7re/668cNwuU8RWx1WWL+HG+ZhC7TSsz8ctacHMZcHfB722vxmAu4ZLBEBjoe/8Mv2RuIc1an X24G0dtV9fpb6Sys5/AjV1eg5zoOyUMA4Kf/7xPCrhs1lU0+tF/YY/PJE0T/+xKvtTVU=; Date: Mon, 8 Dec 2025 17:57:12 +0100 From: Anthony PERARD To: dmukhin@xen.org Cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, anthony.perard@vates.tech, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com, sstabellini@kernel.org, dmukhin@ford.com Subject: Re: [PATCH v1 0/2] tools/tests: test harness fragment Message-ID: References: <20251204123712.721443-1-dmukhin@ford.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251204123712.721443-1-dmukhin@ford.com> On Thu, Dec 04, 2025 at 04:37:10AM -0800, dmukhin@xen.org wrote: > This is a follow-on mini-series based on the original feedback in [1]. > > Patch 1 addresses the remaining feedback from [1]. You mean the feedback about the comment? I guess that's addressed by removing the comment, there's just more unrelated changes in the patch. > Patch 2 adds a new fragment for auto-generating test harness dependencies. I feel like this second patch could be made useful, and easier to review, if a second user of Tests.mk was added. > [1] https://lore.kernel.org/xen-devel/aLmZLm2_G48yfPWR@l14/ > [2] CI: https://gitlab.com/xen-project/people/dmukhin/xen/-/pipelines/2195624771 > > Denis Mukhin (2): > tests: fixup domid test harness dependencies > tests: introduce Tests.mk fragment > > tools/Tests.mk | 34 ++++++++++++++++++++++++++++++++++ If this new file is useful, could you move it "tools/tests/"? BTW, if we really want some generic test harness makefile, maybe looking at what was done for "tools/libs/libs.mk" for example. Cheers, -- Anthony PERARD