From: Peng Fan <peng.fan@oss.nxp.com>
To: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: Vinh Nguyen <vinh.nguyen.xz@renesas.com>,
u-boot@lists.denx.de, Lukasz Majewski <lukma@denx.de>,
Sean Anderson <seanga2@gmail.com>, Peng Fan <peng.fan@nxp.com>,
Tom Rini <trini@konsulko.com>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
Alice Guo <alice.guo@nxp.com>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Valentin Caron <valentin.caron@foss.st.com>,
Kamlesh Gurudasani <kamlesh@ti.com>
Subject: Re: [PATCH 2/3] clk: scmi: Fix priv initialization in scmi_clk_gate()
Date: Tue, 9 Dec 2025 17:00:01 +0800 [thread overview]
Message-ID: <aTflEeNvyzsfJ6Nw@shlinux89> (raw)
In-Reply-To: <20251208-sqqs-v1-2-290f0594e30b@foss.st.com>
On Mon, Dec 08, 2025 at 02:51:26PM +0100, Patrice Chotard wrote:
>In scmi_clk_probe(), in case of CLK_CCF is not enabled, parent private
>data is not set, so in scmi_clk_gate(), an uninitialized priv struct is
>retrieved.
>
>SCMI request is performed either using scmi_clk_state_in_v1 or
>scmi_clk_state_in_v2 struct depending of the unpredictable value of
>priv->version which leads to error during SCMI clock enable.
>
>Issue detected on STM32MP157C-DK2 board using the SCMI device tree
>stm32mp157c-dk2-scmi.dts.
>
>Fixes: 0619cb32030b ("firmware: scmi: Add clock v3.2 CONFIG_SET support")
>
>Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
next prev parent reply other threads:[~2025-12-09 9:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-08 13:51 [PATCH 0/3] clk: scmi: various fixes Patrice Chotard
2025-12-08 13:51 ` [PATCH 1/3] clk: scmi: Fix typo scmi_clk_get_attibute Patrice Chotard
2025-12-09 8:58 ` Peng Fan
2025-12-08 13:51 ` [PATCH 2/3] clk: scmi: Fix priv initialization in scmi_clk_gate() Patrice Chotard
2025-12-09 9:00 ` Peng Fan [this message]
2025-12-09 11:54 ` Marek Vasut
2025-12-11 12:45 ` Peng Fan
2025-12-12 15:16 ` Marek Vasut
2025-12-08 13:51 ` [PATCH 3/3] clk: scmi: Remove duplicated scmi_generic_protocol_version() request Patrice Chotard
2025-12-09 9:01 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTflEeNvyzsfJ6Nw@shlinux89 \
--to=peng.fan@oss.nxp.com \
--cc=alice.guo@nxp.com \
--cc=kamlesh@ti.com \
--cc=lukma@denx.de \
--cc=marek.vasut+renesas@mailbox.org \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=peng.fan@nxp.com \
--cc=seanga2@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=valentin.caron@foss.st.com \
--cc=vinh.nguyen.xz@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.