All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Thaumy Cheng <thaumy.love@gmail.com>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	James Clark <james.clark@linaro.org>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 RESEND] perf/core: Fix missing read event generation on task exit
Date: Tue, 9 Dec 2025 12:23:03 +0100	[thread overview]
Message-ID: <aTgGlzb3VKvNtE9Z@gmail.com> (raw)
In-Reply-To: <20251209093843.GI3707891@noisy.programming.kicks-ass.net>

* Peter Zijlstra <peterz@infradead.org> wrote:

> >
> > -static void sync_child_event(struct perf_event *child_event);
> > +static void sync_child_event(struct perf_event *child_event,
> > +			     struct task_struct *task);
>
> This forward declaration can be entirely removed now.

Indeed - I've applied the delta patch below.

>
> Other than that, yes this seems fine. I see Ingo already picked up the
> patch, thanks!

and I've added your Acked-by as well.

Thanks,

	Ingo

================>
 kernel/events/core.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 47d5dc4bf700..dad0d3d2e85f 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -2317,9 +2317,6 @@ static void perf_group_detach(struct perf_event *event)
 	perf_event__header_size(leader);
 }
 
-static void sync_child_event(struct perf_event *child_event,
-			     struct task_struct *task);
-
 static void perf_child_detach(struct perf_event *event)
 {
 	struct perf_event *parent_event = event->parent;

  reply	other threads:[~2025-12-09 11:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-09  4:16 [PATCH v3 RESEND] perf/core: Fix missing read event generation on task exit Thaumy Cheng
2025-12-09  9:23 ` [tip: perf/urgent] " tip-bot2 for Thaumy Cheng
2025-12-09  9:38 ` [PATCH v3 RESEND] " Peter Zijlstra
2025-12-09 11:23   ` Ingo Molnar [this message]
2025-12-09 11:24 ` [tip: perf/urgent] " tip-bot2 for Thaumy Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aTgGlzb3VKvNtE9Z@gmail.com \
    --to=mingo@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=thaumy.love@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.