From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH v2] resource: add WARN_ON_ONCE for resource_size() and document misusage
Date: Tue, 9 Dec 2025 17:35:02 +0200 [thread overview]
Message-ID: <aThBpvAXlS7Jccja@smile.fi.intel.com> (raw)
In-Reply-To: <aThBMxTF8j8RLDjB@smile.fi.intel.com>
On Tue, Dec 09, 2025 at 05:33:11PM +0200, Andy Shevchenko wrote:
> On Tue, Dec 09, 2025 at 04:01:40PM +0100, Christian Marangi wrote:
...
> > #ifndef __ASSEMBLY__
> > #include <linux/bits.h>
>
> > +#include <linux/bug.h>
>
> Even though it's under non-assembly, please use asm/bug.h where the macro is
> defined. This is a wide used header and putting unrelated stuff into the chain
> is not good and tend to add tangled dependencies in the future (if not now).
>
> > #include <linux/compiler.h>
> > #include <linux/minmax.h>
> > #include <linux/types.h>
To avoid possible misinterpretation of my comment, this should look like
#ifndef __ASSEMBLY__
#include <linux/*.h> // all linux/*.h
...blank line...
#include <asm/bug.h>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-12-09 15:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 15:01 [PATCH v2] resource: add WARN_ON_ONCE for resource_size() and document misusage Christian Marangi
2025-12-09 15:33 ` Andy Shevchenko
2025-12-09 15:35 ` Andy Shevchenko [this message]
2025-12-09 15:48 ` Ilpo Järvinen
2025-12-09 16:06 ` Christian Marangi
2025-12-09 16:45 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aThBpvAXlS7Jccja@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=ansuelsmth@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.