From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4181524A047 for ; Tue, 9 Dec 2025 15:35:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765294507; cv=none; b=U8Wcw64IQLWFYVjNfOSx2F8TMtedi6lRMo1Yg6XqecbXVtknFPPPXLuL5PY19y8DFkO3Xk/vpuzbCJ7LBneQh/iAKUBV0wQSHi3NRdy/4FlnVbYPbMbXu4lLWjLpwv35ZiA9LYV3nvosQpS8I10BSgJG3xr9T28k3kVlGVdued8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765294507; c=relaxed/simple; bh=N9BL0s+DAP0HiEQZNIZIp0IxWNp0p9iNhH7Z6J7ARtw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Sno2r5h5VkvO+3VYHDdXQ9ZujVrFLZ8ZafnDHQ3onQwMf+YupwpGXgeyQ254kmEK/mHjKEGwjqsWoenRRybPEZdUGTxF1CIKsgFSmHRc/AtnzBYyYovo8Qu2kRw7896DqlYL8ExoR74tACqRGPEBPPrBCRoyHDAVPAkZOL3dGcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=gG+Vvitt; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="gG+Vvitt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1765294506; x=1796830506; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=N9BL0s+DAP0HiEQZNIZIp0IxWNp0p9iNhH7Z6J7ARtw=; b=gG+VvittXAU8ul4bknsEI94r7SlUsaUYGUINoNOqETEr5f/r2IrtMcPG 3YUvi+hi0KMysQOcj14WdXoNz3qyKujPR2g9BI8MhCQsMDYSYKEtluDJK iwhF9hr18aLFEpGi4jLsHwAgTY6elUfm9/+TTBszraDAw4Z2u64/YL6qT Fczd8MGwrWwyOLXSvulnz29Feh6Rfekqw1Ggm8a7qDHBaLz2LbazBlBCF r5Mz5ICGnnUQh9gKEr1sGCcCvGsjyjl1JoW7SAq1Un3mfn7rFyyVfZZTq hi5ZHJM2Zm8WEnq3DI1GxiaZJR/3dIVgOZ3Zz0ygliuydWjDvznFZNkHp A==; X-CSE-ConnectionGUID: 3Z+gWPpgShuXtQuSzCHY+Q== X-CSE-MsgGUID: ZdO0McAjRFWDHbGufYzQYg== X-IronPort-AV: E=McAfee;i="6800,10657,11637"; a="78719486" X-IronPort-AV: E=Sophos;i="6.20,261,1758610800"; d="scan'208";a="78719486" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2025 07:35:05 -0800 X-CSE-ConnectionGUID: Q3Tp3i5vQwKUCvgQEjo0Vg== X-CSE-MsgGUID: 3xLc+NcrQ92KtZggw0383g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,261,1758610800"; d="scan'208";a="197030392" Received: from dhhellew-desk2.ger.corp.intel.com (HELO localhost) ([10.245.245.237]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2025 07:35:04 -0800 Date: Tue, 9 Dec 2025 17:35:02 +0200 From: Andy Shevchenko To: Christian Marangi Cc: Andrew Morton , linux-kernel@vger.kernel.org, Ilpo =?iso-8859-1?Q?J=E4rvinen?= Subject: Re: [PATCH v2] resource: add WARN_ON_ONCE for resource_size() and document misusage Message-ID: References: <20251209150150.9525-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, Dec 09, 2025 at 05:33:11PM +0200, Andy Shevchenko wrote: > On Tue, Dec 09, 2025 at 04:01:40PM +0100, Christian Marangi wrote: ... > > #ifndef __ASSEMBLY__ > > #include > > > +#include > > Even though it's under non-assembly, please use asm/bug.h where the macro is > defined. This is a wide used header and putting unrelated stuff into the chain > is not good and tend to add tangled dependencies in the future (if not now). > > > #include > > #include > > #include To avoid possible misinterpretation of my comment, this should look like #ifndef __ASSEMBLY__ #include // all linux/*.h ...blank line... #include -- With Best Regards, Andy Shevchenko