From: Simon Horman <horms@kernel.org>
To: Michael Thalmeier <michael.thalmeier@hale.at>
Cc: Deepak Sharma <deepak.sharma.472935@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] net: nfc: nci: Fix parameter validation for packet data
Date: Tue, 9 Dec 2025 16:31:42 +0000 [thread overview]
Message-ID: <aThO7rm4MqONBurh@horms.kernel.org> (raw)
In-Reply-To: <20251209132103.3736761-1-michael.thalmeier@hale.at>
On Tue, Dec 09, 2025 at 02:21:03PM +0100, Michael Thalmeier wrote:
> Since commit 8fcc7315a10a ("net: nfc: nci: Add parameter validation for
> packet data") communication with nci nfc chips is not working any more.
>
> The mentioned commit tries to fix access of uninitialized data, but
> failed to understand that in some cases the data packet is of variable
> length and can therefore not be compared to the maximum packet length
> given by the sizeof(struct).
>
> For these cases it is only possible to check for minimum packet length.
>
> Fixes: 8fcc7315a10a ("net: nfc: nci: Add parameter validation for packet data")
Hi Michael,
I don't see that hash in net. Perhaps it should be:
Fixes: 9c328f54741b ("net: nfc: nci: Add parameter validation for packet data")
> Cc: stable@vger.kernel.org
> Signed-off-by: Michael Thalmeier <michael.thalmeier@hale.at>
...
next prev parent reply other threads:[~2025-12-09 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 13:21 [PATCH] net: nfc: nci: Fix parameter validation for packet data Michael Thalmeier
2025-12-09 16:31 ` Simon Horman [this message]
2025-12-10 8:01 ` Michael Thalmeier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aThO7rm4MqONBurh@horms.kernel.org \
--to=horms@kernel.org \
--cc=deepak.sharma.472935@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.thalmeier@hale.at \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.