Re: [nft PATCH] datatype: Accept IPv4 addresses for ip6addr_type

[Florian Westphal <fw@strlen.de>]

Phil Sutter <phil@nwl.cc> wrote:
> > > +dnat ip6 to 1.2.3.4;ok;dnat ip6 to ::ffff:1.2.3.4
> > 
> > Pablo, what do you think about this?
> > 
> > I think nft should always return an error here.
> > I don't see how this makes sense (implicit dnat to a
> > mapped address).
> > 
> > Phil/Pablo, do you see a way to limit the 1.2.3.4 -> ::ffff:1.2.3.4
> > expansion to 'add element' ?
> 
> It might be possible for dnat statement to set a flag in eval phase
> controlling ip6addr_type_parse() strictness. This should work even with
> an anonymous map, e.g.

True, but it was more of a usability question, i.e. catch ip vs ipv6
typo in 'dnat ip to 1.2.3.4'.

> | dnat ip6 to ip6 saddr map { fec0::1 : 1.2.3.4 }
> 
> But this could also be a named map and we probably don't want to check
> how it's used before accepting an element.

Right.

> So all this kind of opens pandora's box and we probably either have to
> accept the new ways for users to shoot their feet or:

Yes, indeed.  Or add a cast operator for this.  This was discussed
before (for other things like 'mark set ip saddr').