From: Alice Ryhl <aliceryhl@google.com>
To: Xi Ruoyao <xry111@xry111.site>
Cc: "Huacai Chen" <chenhuacai@kernel.org>,
"WANG Xuerui" <kernel@xen0n.name>,
"Mingcong Bai" <jeffbai@aosc.io>,
loongarch@lists.linux.dev, hev <r@hev.cc>,
"Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Christian Brauner" <brauner@kernel.org>,
"Carlos Llamas" <cmllamas@google.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"open list:ANDROID DRIVERS" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rust_binder: Fix build failure if !CONFIG_COMPAT
Date: Thu, 11 Dec 2025 01:26:06 +0000 [thread overview]
Message-ID: <aTodrqABDzBQXUXD@google.com> (raw)
In-Reply-To: <20251209125029.1117897-1-xry111@xry111.site>
On Tue, Dec 09, 2025 at 08:50:19PM +0800, Xi Ruoyao wrote:
> The bindgen utility cannot handle "#define compat_ptr_ioctl NULL" in the
> C header, so we need to handle this case on our own.
>
> Simply skip this field in the initializer when !CONFIG_COMPAT as the
> SAFETY comment above this initializer implies this is allowed.
>
> Reported-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
> Closes: https://lore.kernel.org/all/CANiq72mrVzqXnAV=Hy2XBOonLHA6YQgH-ckZoc_h0VBvTGK8rA@mail.gmail.com/
> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Thanks!
next prev parent reply other threads:[~2025-12-11 1:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 12:50 [PATCH] rust_binder: Fix build failure if !CONFIG_COMPAT Xi Ruoyao
2025-12-11 1:26 ` Alice Ryhl [this message]
2025-12-27 12:35 ` Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTodrqABDzBQXUXD@google.com \
--to=aliceryhl@google.com \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=cmllamas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jeffbai@aosc.io \
--cc=kernel@xen0n.name \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=r@hev.cc \
--cc=tkjos@android.com \
--cc=wedsonaf@gmail.com \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.